2021-06-17 11:30:11 -04:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#ifndef _LIBCPP___ALGORITHM_UNIQUE_H
|
|
|
|
#define _LIBCPP___ALGORITHM_UNIQUE_H
|
|
|
|
|
|
|
|
#include <__algorithm/adjacent_find.h>
|
2022-01-07 09:45:05 -05:00
|
|
|
#include <__algorithm/comp.h>
|
2022-07-23 01:44:25 +01:00
|
|
|
#include <__algorithm/iterator_operations.h>
|
2022-01-07 09:45:05 -05:00
|
|
|
#include <__config>
|
2024-11-06 12:10:06 +01:00
|
|
|
#include <__functional/identity.h>
|
2021-06-17 11:30:11 -04:00
|
|
|
#include <__iterator/iterator_traits.h>
|
2021-06-05 02:47:47 +00:00
|
|
|
#include <__utility/move.h>
|
2022-07-23 01:44:25 +01:00
|
|
|
#include <__utility/pair.h>
|
2021-06-17 11:30:11 -04:00
|
|
|
|
|
|
|
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
|
2022-02-01 20:16:40 -05:00
|
|
|
# pragma GCC system_header
|
2021-06-17 11:30:11 -04:00
|
|
|
#endif
|
|
|
|
|
[libc++] Fix missing and incorrect push/pop macros (#79204)
We recently noticed that the unwrap_iter.h file was pushing macros, but
it was pushing them again instead of popping them at the end of the
file. This led to libc++ basically swallowing any custom definition of
these macros in user code:
#define min HELLO
#include <algorithm>
// min is not HELLO anymore, it's not defined
While investigating this issue, I noticed that our push/pop pragmas were
actually entirely wrong too. Indeed, instead of pushing macros like
`move`, we'd push `move(int, int)` in the pragma, which is not a valid
macro name. As a result, we would not actually push macros like `move`
-- instead we'd simply undefine them. This led to the following code not
working:
#define move HELLO
#include <algorithm>
// move is not HELLO anymore
Fixing the pragma push/pop incantations led to a cascade of issues
because we use identifiers like `move` in a large number of places, and
all of these headers would now need to do the push/pop dance.
This patch fixes all these issues. First, it adds a check that we don't
swallow important names like min, max, move or refresh as explained
above. This is done by augmenting the existing
system_reserved_names.gen.py test to also check that the macros are what
we expect after including each header.
Second, it fixes the push/pop pragmas to work properly and adds missing
pragmas to all the files I could detect a failure in via the newly added
test.
rdar://121365472
2024-01-25 15:48:46 -05:00
|
|
|
_LIBCPP_PUSH_MACROS
|
|
|
|
#include <__undef_macros>
|
|
|
|
|
2021-06-17 11:30:11 -04:00
|
|
|
_LIBCPP_BEGIN_NAMESPACE_STD
|
|
|
|
|
|
|
|
// unique
|
|
|
|
|
2022-07-23 01:44:25 +01:00
|
|
|
template <class _AlgPolicy, class _Iter, class _Sent, class _BinaryPredicate>
|
2024-09-12 21:18:43 +02:00
|
|
|
[[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 std::pair<_Iter, _Iter>
|
2022-07-23 01:44:25 +01:00
|
|
|
__unique(_Iter __first, _Sent __last, _BinaryPredicate&& __pred) {
|
2024-11-06 12:10:06 +01:00
|
|
|
__identity __proj;
|
|
|
|
__first = std::__adjacent_find(__first, __last, __pred, __proj);
|
2022-07-23 01:44:25 +01:00
|
|
|
if (__first != __last) {
|
|
|
|
// ... a a ? ...
|
|
|
|
// f i
|
|
|
|
_Iter __i = __first;
|
|
|
|
for (++__i; ++__i != __last;)
|
|
|
|
if (!__pred(*__first, *__i))
|
|
|
|
*++__first = _IterOps<_AlgPolicy>::__iter_move(__i);
|
|
|
|
++__first;
|
|
|
|
return std::pair<_Iter, _Iter>(std::move(__first), std::move(__i));
|
|
|
|
}
|
|
|
|
return std::pair<_Iter, _Iter>(__first, __first);
|
|
|
|
}
|
|
|
|
|
2021-06-17 11:30:11 -04:00
|
|
|
template <class _ForwardIterator, class _BinaryPredicate>
|
2024-09-12 21:18:43 +02:00
|
|
|
[[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 _ForwardIterator
|
2022-07-23 01:44:25 +01:00
|
|
|
unique(_ForwardIterator __first, _ForwardIterator __last, _BinaryPredicate __pred) {
|
|
|
|
return std::__unique<_ClassicAlgPolicy>(std::move(__first), std::move(__last), __pred).first;
|
2021-06-17 11:30:11 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
template <class _ForwardIterator>
|
2024-09-12 21:18:43 +02:00
|
|
|
[[__nodiscard__]] inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 _ForwardIterator
|
2022-07-23 01:44:25 +01:00
|
|
|
unique(_ForwardIterator __first, _ForwardIterator __last) {
|
2022-11-22 16:33:35 +08:00
|
|
|
return std::unique(__first, __last, __equal_to());
|
2021-06-17 11:30:11 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
_LIBCPP_END_NAMESPACE_STD
|
|
|
|
|
[libc++] Fix missing and incorrect push/pop macros (#79204)
We recently noticed that the unwrap_iter.h file was pushing macros, but
it was pushing them again instead of popping them at the end of the
file. This led to libc++ basically swallowing any custom definition of
these macros in user code:
#define min HELLO
#include <algorithm>
// min is not HELLO anymore, it's not defined
While investigating this issue, I noticed that our push/pop pragmas were
actually entirely wrong too. Indeed, instead of pushing macros like
`move`, we'd push `move(int, int)` in the pragma, which is not a valid
macro name. As a result, we would not actually push macros like `move`
-- instead we'd simply undefine them. This led to the following code not
working:
#define move HELLO
#include <algorithm>
// move is not HELLO anymore
Fixing the pragma push/pop incantations led to a cascade of issues
because we use identifiers like `move` in a large number of places, and
all of these headers would now need to do the push/pop dance.
This patch fixes all these issues. First, it adds a check that we don't
swallow important names like min, max, move or refresh as explained
above. This is done by augmenting the existing
system_reserved_names.gen.py test to also check that the macros are what
we expect after including each header.
Second, it fixes the push/pop pragmas to work properly and adds missing
pragmas to all the files I could detect a failure in via the newly added
test.
rdar://121365472
2024-01-25 15:48:46 -05:00
|
|
|
_LIBCPP_POP_MACROS
|
|
|
|
|
2021-06-17 11:30:11 -04:00
|
|
|
#endif // _LIBCPP___ALGORITHM_UNIQUE_H
|