2024-12-18 04:39:12 +01:00
|
|
|
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
2025-01-28 09:57:00 +01:00
|
|
|
// RUN: %clang_cc1 -fsyntax-only -fwrapv-pointer -verify=fwrapv %s
|
[Sema] Fix tautological bounds check warning with -fwrapv (#120480)
The tautological bounds check warning added in #120222 does not take
into account whether signed integer overflow is well defined or not,
which could result in a developer removing a bounds check that may not
actually be always false because of different overflow semantics.
```c
int check(const int* foo, unsigned int idx)
{
return foo + idx < foo;
}
```
```
$ clang -O2 -c test.c
test.c:3:19: warning: pointer comparison always evaluates to false [-Wtautological-compare]
3 | return foo + idx < foo;
| ^
1 warning generated.
# Bounds check is eliminated without -fwrapv, warning was correct
$ llvm-objdump -dr test.o
...
0000000000000000 <check>:
0: 31 c0 xorl %eax, %eax
2: c3 retq
```
```
$ clang -O2 -fwrapv -c test.c
test.c:3:19: warning: pointer comparison always evaluates to false [-Wtautological-compare]
3 | return foo + idx < foo;
| ^
1 warning generated.
# Bounds check remains, warning was wrong
$ llvm-objdump -dr test.o
0000000000000000 <check>:
0: 89 f0 movl %esi, %eax
2: 48 8d 0c 87 leaq (%rdi,%rax,4), %rcx
6: 31 c0 xorl %eax, %eax
8: 48 39 f9 cmpq %rdi, %rcx
b: 0f 92 c0 setb %al
e: c3 retq
```
2024-12-18 20:23:50 -07:00
|
|
|
|
|
|
|
// fwrapv-no-diagnostics
|
2024-12-18 04:39:12 +01:00
|
|
|
|
|
|
|
int add_ptr_idx_ult_ptr(const char *ptr, unsigned index) {
|
|
|
|
return ptr + index < ptr; // expected-warning {{pointer comparison always evaluates to false}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int add_idx_ptr_ult_ptr(const char *ptr, unsigned index) {
|
|
|
|
return index + ptr < ptr; // expected-warning {{pointer comparison always evaluates to false}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptr_ugt_add_ptr_idx(const char *ptr, unsigned index) {
|
|
|
|
return ptr > ptr + index; // expected-warning {{pointer comparison always evaluates to false}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptr_ugt_add_idx_ptr(const char *ptr, unsigned index) {
|
|
|
|
return ptr > index + ptr; // expected-warning {{pointer comparison always evaluates to false}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int add_ptr_idx_uge_ptr(const char *ptr, unsigned index) {
|
|
|
|
return ptr + index >= ptr; // expected-warning {{pointer comparison always evaluates to true}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int add_idx_ptr_uge_ptr(const char *ptr, unsigned index) {
|
|
|
|
return index + ptr >= ptr; // expected-warning {{pointer comparison always evaluates to true}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptr_ule_add_ptr_idx(const char *ptr, unsigned index) {
|
|
|
|
return ptr <= ptr + index; // expected-warning {{pointer comparison always evaluates to true}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptr_ule_add_idx_ptr(const char *ptr, unsigned index) {
|
|
|
|
return ptr <= index + ptr; // expected-warning {{pointer comparison always evaluates to true}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int add_ptr_idx_ult_ptr_array(unsigned index) {
|
|
|
|
char ptr[10];
|
|
|
|
return ptr + index < ptr; // expected-warning {{pointer comparison always evaluates to false}}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Negative tests with wrong predicate.
|
|
|
|
|
|
|
|
int add_ptr_idx_ule_ptr(const char *ptr, unsigned index) {
|
|
|
|
return ptr + index <= ptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
int add_ptr_idx_ugt_ptr(const char *ptr, unsigned index) {
|
|
|
|
return ptr + index > ptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptr_uge_add_idx_ptr(const char *ptr, unsigned index) {
|
|
|
|
return ptr >= index + ptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
int ptr_ult_add_idx_ptr(const char *ptr, unsigned index) {
|
|
|
|
return ptr < index + ptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Negative test with signed index.
|
|
|
|
|
|
|
|
int add_ptr_idx_ult_ptr_signed(const char *ptr, int index) {
|
|
|
|
return ptr + index < ptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Negative test with unrelated pointers.
|
|
|
|
|
|
|
|
int add_ptr_idx_ult_ptr2(const char *ptr, const char *ptr2, unsigned index) {
|
|
|
|
return ptr + index < ptr2;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Negative test with non-pointer operands.
|
|
|
|
|
|
|
|
int add_ptr_idx_ult_ptr_not_pointer(unsigned ptr, unsigned index) {
|
|
|
|
return ptr + index < ptr;
|
|
|
|
}
|