2020-10-15 08:38:46 -04:00
|
|
|
//===- ReplaceConstant.cpp - Replace LLVM constant expression--------------===//
|
|
|
|
//
|
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file implements a utility function for replacing LLVM constant
|
|
|
|
// expressions by instructions.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/IR/ReplaceConstant.h"
|
2023-03-03 16:07:43 +01:00
|
|
|
#include "llvm/ADT/SetVector.h"
|
2022-02-23 01:20:48 -08:00
|
|
|
#include "llvm/IR/Constants.h"
|
2020-10-15 08:38:46 -04:00
|
|
|
#include "llvm/IR/Instructions.h"
|
|
|
|
|
|
|
|
namespace llvm {
|
2021-06-08 02:45:18 +05:30
|
|
|
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
static bool isExpandableUser(User *U) {
|
|
|
|
return isa<ConstantExpr>(U) || isa<ConstantAggregate>(U);
|
|
|
|
}
|
|
|
|
|
|
|
|
static Instruction *expandUser(Instruction *InsertPt, Constant *C) {
|
|
|
|
if (auto *CE = dyn_cast<ConstantExpr>(C)) {
|
|
|
|
return CE->getAsInstruction(InsertPt);
|
|
|
|
} else if (isa<ConstantStruct>(C) || isa<ConstantArray>(C)) {
|
|
|
|
Value *V = PoisonValue::get(C->getType());
|
|
|
|
for (auto [Idx, Op] : enumerate(C->operands()))
|
|
|
|
V = InsertValueInst::Create(V, Op, Idx, "", InsertPt);
|
|
|
|
return cast<Instruction>(V);
|
|
|
|
} else if (isa<ConstantVector>(C)) {
|
|
|
|
Type *IdxTy = Type::getInt32Ty(C->getContext());
|
|
|
|
Value *V = PoisonValue::get(C->getType());
|
|
|
|
for (auto [Idx, Op] : enumerate(C->operands()))
|
|
|
|
V = InsertElementInst::Create(V, Op, ConstantInt::get(IdxTy, Idx), "",
|
|
|
|
InsertPt);
|
|
|
|
return cast<Instruction>(V);
|
|
|
|
} else {
|
|
|
|
llvm_unreachable("Not an expandable user");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-03-03 16:07:43 +01:00
|
|
|
bool convertUsersOfConstantsToInstructions(ArrayRef<Constant *> Consts) {
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
// Find all expandable direct users of Consts.
|
|
|
|
SmallVector<Constant *> Stack;
|
2023-03-03 16:07:43 +01:00
|
|
|
for (Constant *C : Consts)
|
|
|
|
for (User *U : C->users())
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
if (isExpandableUser(U))
|
|
|
|
Stack.push_back(cast<Constant>(U));
|
2023-03-03 16:07:43 +01:00
|
|
|
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
// Include transitive users.
|
|
|
|
SetVector<Constant *> ExpandableUsers;
|
2023-03-03 16:07:43 +01:00
|
|
|
while (!Stack.empty()) {
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
Constant *C = Stack.pop_back_val();
|
|
|
|
if (!ExpandableUsers.insert(C))
|
2023-03-03 16:07:43 +01:00
|
|
|
continue;
|
|
|
|
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
for (auto *Nested : C->users())
|
|
|
|
if (isExpandableUser(Nested))
|
|
|
|
Stack.push_back(cast<Constant>(Nested));
|
2023-03-03 16:07:43 +01:00
|
|
|
}
|
|
|
|
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
// Find all instructions that use any of the expandable users
|
2023-03-03 16:07:43 +01:00
|
|
|
SetVector<Instruction *> InstructionWorklist;
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
for (Constant *C : ExpandableUsers)
|
|
|
|
for (User *U : C->users())
|
2023-03-03 16:07:43 +01:00
|
|
|
if (auto *I = dyn_cast<Instruction>(U))
|
|
|
|
InstructionWorklist.insert(I);
|
|
|
|
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
// Replace those expandable operands with instructions
|
2023-03-03 16:07:43 +01:00
|
|
|
bool Changed = false;
|
|
|
|
while (!InstructionWorklist.empty()) {
|
|
|
|
Instruction *I = InstructionWorklist.pop_back_val();
|
|
|
|
for (Use &U : I->operands()) {
|
|
|
|
auto *BI = I;
|
|
|
|
if (auto *Phi = dyn_cast<PHINode>(I)) {
|
|
|
|
BasicBlock *BB = Phi->getIncomingBlock(U);
|
|
|
|
BasicBlock::iterator It = BB->getFirstInsertionPt();
|
|
|
|
assert(It != BB->end() && "Unexpected empty basic block");
|
|
|
|
BI = &*It;
|
|
|
|
}
|
|
|
|
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
if (auto *C = dyn_cast<Constant>(U.get())) {
|
|
|
|
if (ExpandableUsers.contains(C)) {
|
2023-03-03 16:07:43 +01:00
|
|
|
Changed = true;
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
Instruction *NI = expandUser(BI, C);
|
2023-03-03 16:07:43 +01:00
|
|
|
InstructionWorklist.insert(NI);
|
|
|
|
U.set(NI);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Reapply [LowerTypeTests] Avoid creation of select constant expression
Reapply with a fix for phi handling: For phis, we need to insert
into the incoming block, not above the phi. This is especially
tricky if there are multiple incoming values from the same
predecessor, because these must all use the same value.
-----
LowerTypeTests replaces weak declarations with an icmp+select
constant expressions. As this is not a relocatable expression,
it additionally promotes initializers using it to global ctors.
As part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179,
I would like to remove the select constant expression, of which LTT
is now the last user. This is a bit tricky, because we now need to
replace a constant with an instruction, which might require
converting intermediate constant expression users to instructions as
well.
We do this using the convertUsersOfConstantsToInstructions() helper.
However, it needs to be slightly extended to also support expansion
of ConstantAggregates. These are important in this context, because
the promotion of initializers to global ctors will produce stores
of such aggregates.
Differential Revision: https://reviews.llvm.org/D145247
2023-03-03 16:22:41 +01:00
|
|
|
for (Constant *C : Consts)
|
|
|
|
C->removeDeadConstantUsers();
|
|
|
|
|
2023-03-03 16:07:43 +01:00
|
|
|
return Changed;
|
|
|
|
}
|
|
|
|
|
2020-10-15 08:38:46 -04:00
|
|
|
} // namespace llvm
|