mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-30 17:36:06 +00:00
Code Issues Projects Releases Wiki Activity
llvm-project/clang/test/CodeGenCXX/address-space-cast.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

77 lines
3.1 KiB
C++
Raw Normal View History

[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// RUN: %clang_cc1 %s -triple=amdgcn-amd-amdhsa -emit-llvm -o - | FileCheck %s
Sema: Fix explicit address space cast in C++ Currently clang does not allow implicit cast of a pointer to a pointer type in different address space but allows C-style cast of a pointer to a pointer type in different address space. However, there is a bug in Sema causing incorrect Cast Expr in AST for the latter case, which in turn results in invalid LLVM IR in codegen. This is because Sema::IsQualificationConversion returns true for a cast of pointer to a pointer type in different address space, which in turn allows a standard conversion and results in a cast expression with no op in AST. This patch fixes that by let Sema::IsQualificationConversion returns false for a cast of pointer to a pointer type in different address space, which in turn disallows standard conversion, implicit cast, and static cast. Finally it results in an reinterpret cast and correct conversion kind is set. Differential Revision: https://reviews.llvm.org/D49294 llvm-svn: 337540
2018-07-20 11:32:51 +00:00
#define __private__ __attribute__((address_space(5)))
void func_pchar(__private__ char *x);
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
void func_pvoid(__private__ void *x);
void func_pint(__private__ int *x);
Sema: Fix explicit address space cast in C++ Currently clang does not allow implicit cast of a pointer to a pointer type in different address space but allows C-style cast of a pointer to a pointer type in different address space. However, there is a bug in Sema causing incorrect Cast Expr in AST for the latter case, which in turn results in invalid LLVM IR in codegen. This is because Sema::IsQualificationConversion returns true for a cast of pointer to a pointer type in different address space, which in turn allows a standard conversion and results in a cast expression with no op in AST. This patch fixes that by let Sema::IsQualificationConversion returns false for a cast of pointer to a pointer type in different address space, which in turn disallows standard conversion, implicit cast, and static cast. Finally it results in an reinterpret cast and correct conversion kind is set. Differential Revision: https://reviews.llvm.org/D49294 llvm-svn: 337540
2018-07-20 11:32:51 +00:00
[Sema] Iteratively strip sugar when removing address spaces. ASTContext::removeAddrSpaceQualType does not properly deal with sugar. QualTypes derive their ASes from the AS on the canonical type, not the type itself. However, removeAddrSpaceQualType only strips the outermost qualifiers, which means that it can fail to remove addrspace qualifiers if there is sugar in the way. Change the function to desugar types until the address space really no longer exists on the corresponding QualType. This should guarantee the removal of the address space. This fixes the erroneous behavior in D62574. Reviewed By: rjmccall, svenvh Differential Revision: https://reviews.llvm.org/D83325
2020-07-07 19:21:29 +02:00
class Base {
};
class Derived : public Base {
};
void fn(Derived *p) {
__private__ Base *b = (__private__ Base *)p;
}
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK-LABEL: test_cast
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
void test_cast(char *gen_char_ptr, void *gen_void_ptr, int *gen_int_ptr) {
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: store ptr addrspace(5) %[[cast]]
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
__private__ char *priv_char_ptr = (__private__ char *)gen_char_ptr;
Sema: Fix explicit address space cast in C++ Currently clang does not allow implicit cast of a pointer to a pointer type in different address space but allows C-style cast of a pointer to a pointer type in different address space. However, there is a bug in Sema causing incorrect Cast Expr in AST for the latter case, which in turn results in invalid LLVM IR in codegen. This is because Sema::IsQualificationConversion returns true for a cast of pointer to a pointer type in different address space, which in turn allows a standard conversion and results in a cast expression with no op in AST. This patch fixes that by let Sema::IsQualificationConversion returns false for a cast of pointer to a pointer type in different address space, which in turn disallows standard conversion, implicit cast, and static cast. Finally it results in an reinterpret cast and correct conversion kind is set. Differential Revision: https://reviews.llvm.org/D49294 llvm-svn: 337540
2018-07-20 11:32:51 +00:00
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: store ptr addrspace(5) %[[cast]]
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
priv_char_ptr = (__private__ char *)gen_void_ptr;
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: store ptr addrspace(5) %[[cast]]
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
priv_char_ptr = (__private__ char *)gen_int_ptr;
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: store ptr addrspace(5) %[[cast]]
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
__private__ void *priv_void_ptr = (__private__ void *)gen_char_ptr;
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: store ptr addrspace(5) %[[cast]]
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
priv_void_ptr = (__private__ void *)gen_void_ptr;
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: store ptr addrspace(5) %[[cast]]
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
priv_void_ptr = (__private__ void *)gen_int_ptr;
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: store ptr addrspace(5) %[[cast]]
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
__private__ int *priv_int_ptr = (__private__ int *)gen_void_ptr;
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: call void @_Z10func_pcharPU3AS5c(ptr addrspace(5) noundef %[[cast]])
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
func_pchar((__private__ char *)gen_char_ptr);
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: call void @_Z10func_pcharPU3AS5c(ptr addrspace(5) noundef %[[cast]])
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
func_pchar((__private__ char *)gen_void_ptr);
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: call void @_Z10func_pcharPU3AS5c(ptr addrspace(5) noundef %[[cast]])
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
func_pchar((__private__ char *)gen_int_ptr);
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: call void @_Z10func_pvoidPU3AS5v(ptr addrspace(5) noundef %[[cast]])
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
func_pvoid((__private__ void *)gen_char_ptr);
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: call void @_Z10func_pvoidPU3AS5v(ptr addrspace(5) noundef %[[cast]])
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
func_pvoid((__private__ void *)gen_void_ptr);
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: call void @_Z10func_pvoidPU3AS5v(ptr addrspace(5) noundef %[[cast]])
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
func_pvoid((__private__ void *)gen_int_ptr);
[clang] Convert several tests to opaque pointers Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D150829
2023-05-18 02:10:52 +03:00
// CHECK: %[[cast:.*]] = addrspacecast ptr %{{.*}} to ptr addrspace(5)
// CHECK-NEXT: call void @_Z9func_pintPU3AS5i(ptr addrspace(5) noundef %[[cast]])
Sema: Fix explicit address space cast involving void pointers Explicit cast of a void pointer to a pointer type in different address space is incorrectly classified as bitcast, which causes invalid bitcast in codegen. The patch fixes that by checking the address space of the source and destination type and set the correct cast kind. Differential Revision: https://reviews.llvm.org/D50003 llvm-svn: 338805
2018-08-03 03:18:56 +00:00
func_pint((__private__ int *)gen_void_ptr);
Sema: Fix explicit address space cast in C++ Currently clang does not allow implicit cast of a pointer to a pointer type in different address space but allows C-style cast of a pointer to a pointer type in different address space. However, there is a bug in Sema causing incorrect Cast Expr in AST for the latter case, which in turn results in invalid LLVM IR in codegen. This is because Sema::IsQualificationConversion returns true for a cast of pointer to a pointer type in different address space, which in turn allows a standard conversion and results in a cast expression with no op in AST. This patch fixes that by let Sema::IsQualificationConversion returns false for a cast of pointer to a pointer type in different address space, which in turn disallows standard conversion, implicit cast, and static cast. Finally it results in an reinterpret cast and correct conversion kind is set. Differential Revision: https://reviews.llvm.org/D49294 llvm-svn: 337540
2018-07-20 11:32:51 +00:00
}
Reference in New Issue Copy Permalink