[mlir][bazel] Remove implementation from LinalgInterfaces target.

Move LinalgInterfaces.cpp from LinalgInterfaces to LinalgDialect target.

This allows TensorDialect to use header-only RelayoutOpInterface without introducing a hidden dependency on LinalgDialect (producing an `no-allow-shlib-undefined` error if a target depends on TensorDialect but not LinalgDialect).

Also reverts d64f177a2f because it's no longer needed.
This commit is contained in:
Christian Sigg 2025-02-18 20:43:15 +01:00
parent ed14745950
commit 083f80ff6b
2 changed files with 5 additions and 19 deletions

View File

@ -11547,34 +11547,20 @@ cc_library(
cc_library(
name = "LinalgInterfaces",
srcs = [
"include/mlir/Dialect/Linalg/IR/Linalg.h",
"lib/Dialect/Linalg/IR/LinalgInterfaces.cpp",
],
# Note: LinalgInterfaces.cpp is part of LinalgDialect, not this target.
# This allows TensorDialect to use the header-only RelayOpInterface without
# an implicit dependency on the LinalgDialect.
hdrs = ["include/mlir/Dialect/Linalg/IR/LinalgInterfaces.h"],
includes = ["include"],
deps = [
":AffineDialect",
":ArithDialect",
":ArithUtils",
":BytecodeOpInterface",
":ComplexDialect",
":ControlFlowInterfaces",
":CopyOpInterface",
":DestinationStyleOpInterface",
":DialectUtils",
":IR",
":InferTypeOpInterface",
":LinalgEnumsIncGen",
":LinalgInterfacesIncGen",
":LinalgOpsIncGen",
":LinalgRelayoutOpsIncGen",
":LinalgStructuredOpsIncGen",
":SideEffectInterfaces",
":Support",
":TilingInterface",
":ViewLikeInterface",
"//llvm:Support",
],
)
@ -11582,6 +11568,7 @@ cc_library(
name = "LinalgDialect",
srcs = [
"lib/Dialect/Linalg/IR/LinalgDialect.cpp",
"lib/Dialect/Linalg/IR/LinalgInterfaces.cpp",
"lib/Dialect/Linalg/IR/LinalgOps.cpp",
"lib/Dialect/Linalg/IR/ValueBoundsOpInterfaceImpl.cpp",
],
@ -11608,6 +11595,7 @@ cc_library(
":InliningUtils",
":LinalgEnumsIncGen",
":LinalgInterfaces",
":LinalgInterfacesIncGen",
":LinalgNamedStructuredOpsYamlIncGen",
":LinalgOpsIncGen",
":LinalgRelayoutOpsIncGen",

View File

@ -176,7 +176,6 @@ cc_test(
"//mlir:ArithDialect",
"//mlir:FuncDialect",
"//mlir:IR",
"//mlir:LinalgDialect",
"//mlir:Parser",
"//mlir:SCFDialect",
"//mlir:SideEffectInterfaces",
@ -212,7 +211,6 @@ cc_test(
"//llvm:Support",
"//llvm:TestingSupport",
"//mlir:IR",
"//mlir:LinalgDialect",
"//mlir:SPIRVBinaryUtils",
"//mlir:SPIRVDeserialization",
"//mlir:SPIRVDialect",