mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-16 11:56:38 +00:00
Code Issues Projects Releases Wiki Activity

[lldb] Fix memory leak in CommandObjectType

Browse Source 
Avoid leaking the ScriptAddOptions or SynthAddOptions when we return
early because of an empty type name.
This commit is contained in:
Jonas Devlieghere 2022-02-16 08:58:38 -08:00
parent 2e3bb910e3
commit 0c58e9f4a4
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lldb/source/Commands/CommandObjectType.cpp
View File

@ -1337,9 +1337,9 @@ bool CommandObjectTypeSummaryAdd::Execute_ScriptSummary(
m_options.m_flags, funct_name_str.c_str(), code.c_str());
} else {
// Use an IOHandler to grab Python code from the user
ScriptAddOptions *options =
new ScriptAddOptions(m_options.m_flags, m_options.m_regex,
m_options.m_name, m_options.m_category);
auto options = std::make_unique<ScriptAddOptions>(
m_options.m_flags, m_options.m_regex, m_options.m_name,
m_options.m_category);
for (auto &entry : command.entries()) {
if (entry.ref().empty()) {
@ -1351,10 +1351,10 @@ bool CommandObjectTypeSummaryAdd::Execute_ScriptSummary(
}
m_interpreter.GetPythonCommandsFromIOHandler(
" ", // Prompt
*this, // IOHandlerDelegate
options); // Baton for the "io_handler" that will be passed back into
// our IOHandlerDelegate functions
" ", // Prompt
*this, // IOHandlerDelegate
options.release()); // Baton for the "io_handler" that will be passed
// back into our IOHandlerDelegate functions
result.SetStatus(eReturnStatusSuccessFinishNoResult);
return result.Succeeded();
@ -2252,7 +2252,7 @@ public:
bool CommandObjectTypeSynthAdd::Execute_HandwritePython(
Args &command, CommandReturnObject &result) {
SynthAddOptions *options = new SynthAddOptions(
auto options = std::make_unique<SynthAddOptions>(
m_options.m_skip_pointers, m_options.m_skip_references,
m_options.m_cascade, m_options.m_regex, m_options.m_category);
@ -2266,10 +2266,10 @@ bool CommandObjectTypeSynthAdd::Execute_HandwritePython(
}
m_interpreter.GetPythonCommandsFromIOHandler(
" ", // Prompt
*this, // IOHandlerDelegate
options); // Baton for the "io_handler" that will be passed back into our
// IOHandlerDelegate functions
" ", // Prompt
*this, // IOHandlerDelegate
options.release()); // Baton for the "io_handler" that will be passed back
// into our IOHandlerDelegate functions
result.SetStatus(eReturnStatusSuccessFinishNoResult);
return result.Succeeded();
}