mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-25 06:36:06 +00:00
Code Issues Projects Releases Wiki Activity

[Coroutines] Don't assert if coro-early runs more than once (#134854)

Browse Source 
The pass may run more than once during ThinLTO for example (see bug).
Maybe that means those pass pipelines aren't optimal, but the pass
should be resilient against that.

Fixes #134054
This commit is contained in:
Hans Wennborg 2025-04-09 18:59:02 +02:00 committed by GitHub
parent f0131c327e
commit 0eb560a4de
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 38 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/include/llvm/Transforms/Coroutines/CoroInstr.h
View File

@ -217,8 +217,8 @@ public:
return cast<Function>(getArgOperand(CoroutineArg)->stripPointerCasts());
}
void setCoroutineSelf() {
assert(isa<ConstantPointerNull>(getArgOperand(CoroutineArg)) &&
"Coroutine argument is already assigned");
if (!isa<ConstantPointerNull>(getArgOperand(CoroutineArg)))
assert(getCoroutine() == getFunction() && "Don't change coroutine.");
setArgOperand(CoroutineArg, getFunction());
}

36
llvm/test/Transforms/Coroutines/coro-early-twice.ll Normal file
View File

@ -0,0 +1,36 @@
; RUN: opt < %s -passes='module(coro-early,coro-early)' -S | FileCheck %s
; Check that coro-early can run twice without asserting/crashing.
; CHECK-LABEL: define ptr @f
; CHECK: call token @llvm.coro.id(i32 0, ptr null, ptr @f, ptr null)
define ptr @f(i32 %n) presplitcoroutine {
entry:
%id = call token @llvm.coro.id(i32 0, ptr null, ptr null, ptr null)
%size = call i32 @llvm.coro.size.i32()
%alloc = call ptr @malloc(i32 %size)
%hdl = call ptr @llvm.coro.begin(token %id, ptr %alloc)
%sp1 = call i8 @llvm.coro.suspend(token none, i1 false)
switch i8 %sp1, label %suspend [i8 0, label %resume1
i8 1, label %cleanup]
resume1:
br label %cleanup
cleanup:
%mem = call ptr @llvm.coro.free(token %id, ptr %hdl)
call void @free(ptr %mem)
br label %suspend
suspend:
call i1 @llvm.coro.end(ptr %hdl, i1 0, token none)
ret ptr %hdl
}
declare token @llvm.coro.id(i32, ptr, ptr, ptr)
declare i32 @llvm.coro.size.i32()
declare noalias ptr @malloc(i32)
declare ptr @llvm.coro.begin(token, ptr)
declare i8 @llvm.coro.suspend(token, i1)
declare ptr @llvm.coro.free(token, ptr)
declare void @free(ptr)
declare i1 @llvm.coro.end(ptr, i1, token)