mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-05-17 14:46:07 +00:00
Code Issues Projects Releases Wiki Activity

Added warning about invalid register specification for local variables.

Browse Source 
llvm-svn: 123236
This commit is contained in:
Abramo Bagnara 2011-01-11 15:16:52 +00:00
parent c8adf5f458
commit 1339223186
3 changed files with 31 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/include/clang/Basic/DiagnosticSemaKinds.td
View File

@ -3029,6 +3029,8 @@ let CategoryName = "Inline Assembly Issue" in {
def err_asm_tying_incompatible_types : Error< def err_asm_tying_incompatible_types : Error<
"unsupported inline asm: input with type %0 matching output with type %1">; "unsupported inline asm: input with type %0 matching output with type %1">;
def err_asm_unknown_register_name : Error<"unknown register name '%0' in asm">; def err_asm_unknown_register_name : Error<"unknown register name '%0' in asm">;
def warn_asm_label_on_auto_decl : Warning<
"ignored asm label '%0' on automatic variable">;
def err_invalid_asm_cast_lvalue : Error< def err_invalid_asm_cast_lvalue : Error<
"invalid use of a cast in a inline asm context requiring an l-value: " "invalid use of a cast in a inline asm context requiring an l-value: "
"remove the cast or build with -fheinous-gnu-extensions">; "remove the cast or build with -fheinous-gnu-extensions">;

22
clang/lib/Sema/SemaDecl.cpp
View File

@ -2997,10 +2997,24 @@ Sema::ActOnVariableDeclarator(Scope *S, Declarator &D, DeclContext *DC,
// The parser guarantees this is a string. // The parser guarantees this is a string.
StringLiteral *SE = cast<StringLiteral>(E); StringLiteral *SE = cast<StringLiteral>(E);
llvm::StringRef Label = SE->getString(); llvm::StringRef Label = SE->getString();
if (S->getFnParent() != 0 && if (S->getFnParent() != 0) {
!Context.Target.isValidGCCRegisterName(Label)) switch (SC) {
Diag(E->getExprLoc(), diag::err_asm_unknown_register_name) << Label; case SC_None:
NewVD->addAttr(::new (Context) AsmLabelAttr(SE->getStrTokenLoc(0), case SC_Auto:
Diag(E->getExprLoc(), diag::warn_asm_label_on_auto_decl) << Label;
break;
case SC_Register:
if (!Context.Target.isValidGCCRegisterName(Label))
Diag(E->getExprLoc(), diag::err_asm_unknown_register_name) << Label;
break;
case SC_Static:
case SC_Extern:
case SC_PrivateExtern:
break;
}
}
NewVD->addAttr(::new (Context) AsmLabelAttr(SE->getStrTokenLoc(0),
Context, Label)); Context, Label));
} }

12
clang/test/Sema/asm.c
View File

@ -92,6 +92,16 @@ void test9(int i) {
asm("" : [foo] "=r" (i), "=r"(i) : "[foo]1"(i)); // expected-error{{invalid input constraint '[foo]1' in asm}} asm("" : [foo] "=r" (i), "=r"(i) : "[foo]1"(i)); // expected-error{{invalid input constraint '[foo]1' in asm}}
} }
register int g asm("dx"); // expected-error{{global register variables are not supported}}
void test10(void){ void test10(void){
register unsigned long long bar asm("foo"); // expected-error {{unknown register name 'foo' in asm}} static int g asm ("g_asm") = 0;
extern int gg asm ("gg_asm");
__private_extern__ int ggg asm ("ggg_asm");
int a asm ("a_asm"); // expected-warning{{ignored asm label 'a_asm' on automatic variable}}
auto int aa asm ("aa_asm"); // expected-warning{{ignored asm label 'aa_asm' on automatic variable}}
register int r asm ("cx");
register int rr asm ("rr_asm"); // expected-error{{unknown register name 'rr_asm' in asm}}
} }