mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 18:56:43 +00:00
Code Issues Projects Releases Wiki Activity

[LLD] [COFF] Don't preserve unnecessary __imp_ prefixed symbols (#72989)

Browse Source 
This redoes the fix from 3ab6209a3f93bdbeec8e9b9fcc00a9a4980915ff
differently, without the unwanted effect of preserving unnecessary
`__imp_` prefixed symbols.

If the referencing object is a regular object, the `__imp_` symbol will
have `isUsedInRegularObj` set on it from that already. If the
referencing object is an LTO object, we set `isUsedInRegularObj` for any
symbol starting with `__imp_`.

If the object file defining the `__imp_` symbol is a regular object, the
`isUsedInRegularObj` flag has no effect. If it is an LTO object, it
causes the symbol to be preserved.
This commit is contained in:
Martin Storsjö 2023-12-04 23:38:46 +02:00 committed by GitHub
parent 8dc474c6b7
commit 143133fe68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lld/COFF/InputFiles.cpp
View File

@ -1042,6 +1042,19 @@ void BitcodeFile::parse() {
sym = ctx.symtab.addUndefined(symName, this, false);
if (objSym.isWeak())
sym->deferUndefined = true;
// If one LTO object file references (i.e. has an undefined reference to)
// a symbol with an __imp_ prefix, the LTO compilation itself sees it
// as unprefixed but with a dllimport attribute instead, and doesn't
// understand the relation to a concrete IR symbol with the __imp_ prefix.
//
// For such cases, mark the symbol as used in a regular object (i.e. the
// symbol must be retained) so that the linker can associate the
// references in the end. If the symbol is defined in an import library
// or in a regular object file, this has no effect, but if it is defined
// in another LTO object file, this makes sure it is kept, to fulfill
// the reference when linking the output of the LTO compilation.
if (symName.starts_with("__imp_"))
sym->isUsedInRegularObj = true;
} else if (objSym.isCommon()) {
sym = ctx.symtab.addCommon(this, symName, objSym.getCommonSize());
} else if (objSym.isWeak() && objSym.isIndirect()) {
@ -1063,12 +1076,6 @@ void BitcodeFile::parse() {
} else {
sym = ctx.symtab.addRegular(this, symName, nullptr, fakeSC, 0,
objSym.isWeak());
// Model all symbols with the __imp_ prefix as having external
// references. If one LTO object defines a __imp_<foo> symbol, and
// another LTO object refers to <foo> with dllimport, make sure the
// __imp_ symbol is kept.
if (symName.starts_with("__imp_"))
sym->isUsedInRegularObj = true;
}
symbols.push_back(sym);
if (objSym.isUsed())

8
lld/test/COFF/lto-imp-prefix.ll
View File

@ -8,13 +8,9 @@
; RUN: lld-link /entry:entry %t.main.obj %t.other1.obj /out:%t1.exe /subsystem:console /debug:symtab
;; The current implementation for handling __imp_ symbols retains all of them.
;; Observe that this currently produces __imp_unusedFunc even if nothing
;; references unusedFunc in any form.
;; Check that we don't retain __imp_ prefixed symbols we don't need.
; RUN: llvm-nm %t1.exe | FileCheck %s
; CHECK: __imp_unusedFunc
; CHECK-NOT: __imp_unusedFunc
; RUN: lld-link /entry:entry %t.main.obj %t.other2.obj /out:%t2.exe /subsystem:console