mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-26 03:06:06 +00:00
Code Issues Projects Releases Wiki Activity

Check if an attribute is in the builtin dialect before going through all the possible combinations (NFC)

Browse Source 
This is just a "micro-optimization" noticed through code review.

Differential Revision: https://reviews.llvm.org/D112984
This commit is contained in:
Mehdi Amini 2021-11-02 05:51:38 +00:00
parent 6bdb61c58a
commit 19ced834cc
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mlir/lib/IR/AsmPrinter.cpp
View File

@ -16,6 +16,7 @@
#include "mlir/IR/AsmState.h"
#include "mlir/IR/Attributes.h"
#include "mlir/IR/Builders.h"
#include "mlir/IR/BuiltinDialect.h"
#include "mlir/IR/BuiltinTypes.h"
#include "mlir/IR/Dialect.h"
#include "mlir/IR/DialectImplementation.h"
@ -1608,6 +1609,9 @@ void AsmPrinter::Impl::printAttribute(Attribute attr,
if (state && succeeded(state->getAliasState().getAlias(attr, os)))
return;
if (!isa<BuiltinDialect>(attr.getDialect()))
return printDialectAttribute(attr);
auto attrType = attr.getType();
if (auto opaqueAttr = attr.dyn_cast<OpaqueAttr>()) {
printDialectSymbol(os, "#", opaqueAttr.getDialectNamespace(),
@ -1728,11 +1732,7 @@ void AsmPrinter::Impl::printAttribute(Attribute attr,
} else if (auto locAttr = attr.dyn_cast<LocationAttr>()) {
printLocation(locAttr);
} else {
return printDialectAttribute(attr);
}
// Don't print the type if we must elide it, or if it is a None type.
if (typeElision != AttrTypeElision::Must && !attrType.isa<NoneType>()) {
os << " : ";