mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-16 03:36:38 +00:00
Code Issues Projects Releases Wiki Activity

[libc++][hardening][NFC] Remove the LIBCXX_DEBUG_BUILD CMake variable.

Browse Source 
It's no longer necessary to define `_DEBUG` because we use our own
internal assertion mechanism in libc++.

Differential Revision: https://reviews.llvm.org/D155038
This commit is contained in:
varconst 2023-07-11 20:18:20 -07:00
parent 6ed48ebf2e
commit 1ba514c2cb
1 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libcxx/CMakeLists.txt
View File

@ -480,13 +480,6 @@ if (LIBCXX_GENERATE_COVERAGE)
set(CMAKE_BUILD_TYPE "COVERAGE" CACHE STRING "" FORCE)
endif()
string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
if (uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
set(LIBCXX_DEBUG_BUILD ON)
else()
set(LIBCXX_DEBUG_BUILD OFF)
endif()
#===============================================================================
# Setup Compiler Flags
#===============================================================================
@ -595,13 +588,6 @@ if (LIBCXX_BUILD_EXTERNAL_THREAD_LIBRARY AND LIBCXX_ENABLE_SHARED)
endif()
endif()
# Assertion flags =============================================================
define_if(LIBCXX_DEBUG_BUILD -D_DEBUG)
if (LIBCXX_ENABLE_ASSERTIONS AND NOT LIBCXX_DEBUG_BUILD)
# MSVC doesn't like _DEBUG on release builds. See PR 4379.
define_if_not(MSVC -D_DEBUG)
endif()
# Modules flags ===============================================================
# FIXME The libc++ sources are fundamentally non-modular. They need special
# versions of the headers in order to provide C++03 and legacy ABI definitions.
@ -614,6 +600,8 @@ function(cxx_add_module_flags target)
endif()
endfunction()
string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
# Sanitizer flags =============================================================
function(get_sanitizer_flags OUT_VAR USE_SANITIZER)
@ -721,7 +709,7 @@ function(cxx_link_system_libraries target)
endif()
if (MSVC)
if (LIBCXX_DEBUG_BUILD)
if (uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
set(LIB_SUFFIX "d")
else()
set(LIB_SUFFIX "")