mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-05-07 20:06:06 +00:00
Code Issues Projects Releases Wiki Activity

[Frontend] Remove unused TemporaryFiles

Browse Source 
Summary:
OnDiskData.TemporaryFiles is filled only by ASTUnit::addTemporaryFile, which is
dead. Also these files are used nowhere in the frontend nor in libclang.

Reviewers: bkramer, ilya-biryukov

Reviewed By: bkramer, ilya-biryukov

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D33270

llvm-svn: 303265
This commit is contained in:
Krasimir Georgiev 2017-05-17 14:51:44 +00:00
parent 21375185e7
commit 1f64bf6c69
2 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/include/clang/Frontend/ASTUnit.h
View File

@ -419,7 +419,6 @@ private:
explicit ASTUnit(bool MainFileIsAST); explicit ASTUnit(bool MainFileIsAST);
void CleanTemporaryFiles();
bool Parse(std::shared_ptr<PCHContainerOperations> PCHContainerOps, bool Parse(std::shared_ptr<PCHContainerOperations> PCHContainerOps,
std::unique_ptr<llvm::MemoryBuffer> OverrideMainBuffer); std::unique_ptr<llvm::MemoryBuffer> OverrideMainBuffer);
@ -530,11 +529,6 @@ public:
ASTMutationListener *getASTMutationListener(); ASTMutationListener *getASTMutationListener();
ASTDeserializationListener *getDeserializationListener(); ASTDeserializationListener *getDeserializationListener();
/// \brief Add a temporary file that the ASTUnit depends on.
///
/// This file will be erased when the ASTUnit is destroyed.
void addTemporaryFile(StringRef TempFile);
bool getOnlyLocalDecls() const { return OnlyLocalDecls; } bool getOnlyLocalDecls() const { return OnlyLocalDecls; }
bool getOwnsRemappedFileBuffers() const { return OwnsRemappedFileBuffers; } bool getOwnsRemappedFileBuffers() const { return OwnsRemappedFileBuffers; }

23
clang/lib/Frontend/ASTUnit.cpp
View File

@ -84,13 +84,6 @@ namespace {
/// \brief The file in which the precompiled preamble is stored. /// \brief The file in which the precompiled preamble is stored.
std::string PreambleFile; std::string PreambleFile;
/// \brief Temporary files that should be removed when the ASTUnit is
/// destroyed.
SmallVector<std::string, 4> TemporaryFiles;
/// \brief Erase temporary files.
void CleanTemporaryFiles();
/// \brief Erase the preamble file. /// \brief Erase the preamble file.
void CleanPreambleFile(); void CleanPreambleFile();
@ -163,12 +156,6 @@ static const std::string &getPreambleFile(const ASTUnit *AU) {
return getOnDiskData(AU).PreambleFile; return getOnDiskData(AU).PreambleFile;
} }
void OnDiskData::CleanTemporaryFiles() {
for (StringRef File : TemporaryFiles)
llvm::sys::fs::remove(File);
TemporaryFiles.clear();
}
void OnDiskData::CleanPreambleFile() { void OnDiskData::CleanPreambleFile() {
if (!PreambleFile.empty()) { if (!PreambleFile.empty()) {
llvm::sys::fs::remove(PreambleFile); llvm::sys::fs::remove(PreambleFile);
@ -177,7 +164,6 @@ void OnDiskData::CleanPreambleFile() {
} }
void OnDiskData::Cleanup() { void OnDiskData::Cleanup() {
CleanTemporaryFiles();
CleanPreambleFile(); CleanPreambleFile();
} }
@ -194,14 +180,6 @@ void ASTUnit::clearFileLevelDecls() {
llvm::DeleteContainerSeconds(FileDecls); llvm::DeleteContainerSeconds(FileDecls);
} }
void ASTUnit::CleanTemporaryFiles() {
getOnDiskData(this).CleanTemporaryFiles();
}
void ASTUnit::addTemporaryFile(StringRef TempFile) {
getOnDiskData(this).TemporaryFiles.push_back(TempFile);
}
/// \brief After failing to build a precompiled preamble (due to /// \brief After failing to build a precompiled preamble (due to
/// errors in the source that occurs in the preamble), the number of /// errors in the source that occurs in the preamble), the number of
/// reparses during which we'll skip even trying to precompile the /// reparses during which we'll skip even trying to precompile the
@ -1100,7 +1078,6 @@ bool ASTUnit::Parse(std::shared_ptr<PCHContainerOperations> PCHContainerOps,
// Clear out old caches and data. // Clear out old caches and data.
TopLevelDecls.clear(); TopLevelDecls.clear();
clearFileLevelDecls(); clearFileLevelDecls();
CleanTemporaryFiles();
if (!OverrideMainBuffer) { if (!OverrideMainBuffer) {
checkAndRemoveNonDriverDiags(StoredDiagnostics); checkAndRemoveNonDriverDiags(StoredDiagnostics);