mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 15:36:58 +00:00
Code Issues Projects Releases Wiki Activity

[webkit.RefCntblBaseVirtualDtor] Add support for NoVirtualDestructorBase. (#132497)

Browse Source 
This PR adds the support for WTF::NoVirtualDestructorBase, which
signifies to the checker that the class is exempt from having a virtual
destructor.
This commit is contained in:
Ryosuke Niwa 2025-03-26 16:57:49 -07:00 committed by GitHub
parent 3386156b1e
commit 2b43ecd27b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang/lib/StaticAnalyzer/Checkers/WebKit/RefCntblBaseVirtualDtorChecker.cpp
View File

@ -202,6 +202,13 @@ public:
if (!C)
continue;
bool isExempt = T.getAsString() == "NoVirtualDestructorBase" &&
safeGetName(C->getParent()) == "WTF";
if (isExempt || ExemptDecls.contains(C)) {
ExemptDecls.insert(RD);
continue;
}
if (auto *CTSD = dyn_cast<ClassTemplateSpecializationDecl>(C)) {
for (auto &Arg : CTSD->getTemplateArgs().asArray()) {
if (Arg.getKind() != TemplateArgument::Type)
@ -223,12 +230,13 @@ public:
llvm::SetVector<const CXXRecordDecl *> Decls;
llvm::DenseSet<const CXXRecordDecl *> CRTPs;
llvm::DenseSet<const CXXRecordDecl *> ExemptDecls;
};
LocalVisitor visitor(this);
visitor.TraverseDecl(const_cast<TranslationUnitDecl *>(TUD));
for (auto *RD : visitor.Decls) {
if (visitor.CRTPs.contains(RD))
if (visitor.CRTPs.contains(RD) || visitor.ExemptDecls.contains(RD))
continue;
visitCXXRecordDecl(RD);
}

17
clang/test/Analysis/Checkers/WebKit/ref-cntbl-base-virtual-dtor.cpp
View File

@ -1,5 +1,13 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=webkit.RefCntblBaseVirtualDtor -verify %s
namespace WTF {
class NoVirtualDestructorBase { };
};
using WTF::NoVirtualDestructorBase;
struct RefCntblBase {
void ref() {}
void deref() {}
@ -19,6 +27,15 @@ struct [[clang::suppress]] SuppressedDerivedWithVirtualDtor : RefCntblBase {
virtual ~SuppressedDerivedWithVirtualDtor() {}
};
class ClassWithoutVirtualDestructor : public NoVirtualDestructorBase {
public:
void ref() const;
void deref() const;
};
class DerivedClassWithoutVirtualDestructor : public ClassWithoutVirtualDestructor {
};
// FIXME: Support attributes on base specifiers? Currently clang
// doesn't support such attributes at all, even though it knows
// how to parse them.