mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 19:16:43 +00:00
Code Issues Projects Releases Wiki Activity

[Clang] Error on extraneous template headers by default. (#104046)

Browse Source 
As discussed here

https://github.com/llvm/llvm-project/issues/99296#issuecomment-2240807413

Fixes #99296
Fixes #50294
This commit is contained in:
cor3ntin 2024-08-15 00:55:54 +02:00 committed by GitHub
parent 539bf49961
commit 2b959bd7f2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
clang/docs/ReleaseNotes.rst
View File

@ -65,6 +65,15 @@ C++ Specific Potentially Breaking Changes
`-Wno-enum-constexpr-conversion`, to allow for a transition period for users.
Now, in Clang 20, **it is no longer possible to suppress the diagnostic**.
- Extraneous template headers are now ill-formed by default.
This error can be disable with ``-Wno-error=extraneous-template-head``.
.. code-block:: c++
template <> // error: extraneous template head
template <typename T>
void f();
ABI Changes in This Version
---------------------------

3
clang/include/clang/Basic/DiagnosticSemaKinds.td
View File

@ -5428,7 +5428,8 @@ def err_template_spec_extra_headers : Error<
"extraneous template parameter list in template specialization or "
"out-of-line template definition">;
def ext_template_spec_extra_headers : ExtWarn<
"extraneous template parameter list in template specialization">;
"extraneous template parameter list in template specialization">,
InGroup<DiagGroup<"extraneous-template-head">>, DefaultError;
def note_explicit_template_spec_does_not_need_header : Note<
"'template<>' header not required for explicitly-specialized class %0 "
"declared here">;

3
clang/test/Misc/warning-flags.c
View File

@ -18,14 +18,13 @@ This test serves two purposes:
The list of warnings below should NEVER grow. It should gradually shrink to 0.
CHECK: Warnings without flags (65):
CHECK: Warnings without flags (64):
CHECK-NEXT: ext_expected_semi_decl_list
CHECK-NEXT: ext_missing_whitespace_after_macro_name
CHECK-NEXT: ext_new_paren_array_nonconst
CHECK-NEXT: ext_plain_complex
CHECK-NEXT: ext_template_arg_extra_parens
CHECK-NEXT: ext_template_spec_extra_headers
CHECK-NEXT: ext_typecheck_cond_incompatible_operands
CHECK-NEXT: ext_typecheck_ordered_comparison_of_pointer_integer
CHECK-NEXT: ext_using_undefined_std

7
clang/test/SemaTemplate/temp_explicit.cpp
View File

@ -1,6 +1,7 @@
// RUN: %clang_cc1 -fsyntax-only -verify -pedantic -Wc++11-compat %s
// RUN: %clang_cc1 -fsyntax-only -verify -pedantic -Wc++11-compat -std=c++98 %s
// RUN: %clang_cc1 -fsyntax-only -verify -pedantic -std=c++11 %s
// RUN: %clang_cc1 -fsyntax-only -verify -pedantic -std=c++20 %s
//
// Tests explicit instantiation of templates.
template<typename T, typename U = T> class X0 { };
@ -128,11 +129,15 @@ struct Foo<int> // expected-note{{header not required for explicitly-specialized
{};
};
template <> // expected-warning{{extraneous template parameter list}}
template <> // expected-error{{extraneous template parameter list}}
template <>
struct Foo<int>::Bar<void>
{};
#if __cplusplus >= 202002L
template<> void f(auto); // expected-error{{extraneous template parameter list}}
#endif
namespace N1 {
template<typename T> struct X7 { }; // expected-note{{here}}