From 30ae47eeefaeb2c78ae7f234621b8bb0444b7844 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Mon, 7 Apr 2025 21:56:00 +0700 Subject: [PATCH] SCEVExpander: Don't look at uses of constants (#134691) This could be more relaxed, and look for uses of globals in the same function but no tests apparently depend on that. --- .../Utils/ScalarEvolutionExpander.cpp | 29 ++++++++++--------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp b/llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp index 41bf202230e2..e25ec6c3b2a5 100644 --- a/llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp +++ b/llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp @@ -111,20 +111,23 @@ Value *SCEVExpander::ReuseOrCreateCast(Value *V, Type *Ty, Value *Ret = nullptr; - // Check to see if there is already a cast! - for (User *U : V->users()) { - if (U->getType() != Ty) - continue; - CastInst *CI = dyn_cast(U); - if (!CI || CI->getOpcode() != Op) - continue; + if (!isa(V)) { + // Check to see if there is already a cast! + for (User *U : V->users()) { + if (U->getType() != Ty) + continue; + CastInst *CI = dyn_cast(U); + if (!CI || CI->getOpcode() != Op) + continue; - // Found a suitable cast that is at IP or comes before IP. Use it. Note that - // the cast must also properly dominate the Builder's insertion point. - if (IP->getParent() == CI->getParent() && &*BIP != CI && - (&*IP == CI || CI->comesBefore(&*IP))) { - Ret = CI; - break; + // Found a suitable cast that is at IP or comes before IP. Use it. Note + // that the cast must also properly dominate the Builder's insertion + // point. + if (IP->getParent() == CI->getParent() && &*BIP != CI && + (&*IP == CI || CI->comesBefore(&*IP))) { + Ret = CI; + break; + } } }