mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 18:56:43 +00:00
Code Issues Projects Releases Wiki Activity

[flang] Fix crash on SMP with dummy procedure (#124663)

Browse Source 
When a separate module procedure is defined with MODULE PROCEDURE, the
compiler crashes if there is a dummy procedure in the interface defined
with only a result type. This is due to the type already having been
defined on the ProcEntityDetails symbol as part of earlier wholesale
symbol duplication. Adjust the code to not define the result type of the
ProcEntityDetails if it is already present, but to verify that it is the
same type instead.

Fixes https://github.com/llvm/llvm-project/issues/124487.
This commit is contained in:
Peter Klausler 2025-01-31 10:52:34 -08:00 committed by GitHub
parent 8d8a821b78
commit 36caa8f9e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
flang/lib/Semantics/resolve-names-utils.cpp
View File

@ -762,7 +762,11 @@ void SymbolMapper::MapSymbolExprs(Symbol &symbol) {
proc.set_procInterfaces(
*mappedSymbol, BypassGeneric(mappedSymbol->GetUltimate()));
} else if (const DeclTypeSpec * mappedType{MapType(proc.type())}) {
proc.set_type(*mappedType);
if (proc.type()) {
CHECK(*proc.type() == *mappedType);
} else {
proc.set_type(*mappedType);
}
}
if (proc.init()) {
if (const Symbol * mapped{MapSymbol(*proc.init())}) {

14
flang/test/Semantics/bug124487.f90 Normal file
View File

@ -0,0 +1,14 @@
!RUN: %flang_fc1 -fsyntax-only %s 2>&1 | FileCheck --allow-empty %s
!CHECK-NOT: error:
module m
interface
module subroutine smp(x)
character, external :: x
end
end interface
end
submodule (m) sm
contains
module procedure smp ! crashes here
end
end