mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-05-02 20:46:06 +00:00
Code Issues Projects Releases Wiki Activity

[BranchFolder] Skip redundant IMPLICIT_DEFs of subregs

Browse Source 
Differential Revision: https://reviews.llvm.org/D148509
This commit is contained in:
Jay Foad 2023-04-17 11:06:06 +01:00
parent 12b70ad68c
commit 47d3cbcf84
2 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/lib/CodeGen/BranchFolding.cpp
View File

@ -860,6 +860,14 @@ void BranchFolder::mergeCommonTails(unsigned commonTailIndex) {
for (Register Reg : NewLiveIns) {
if (!LiveRegs.available(*MRI, Reg))
continue;
// Skip the register if we are about to add one of its super registers.
// TODO: Common this up with the same logic in addLineIns().
if (any_of(TRI->superregs(Reg), [&](MCPhysReg SReg) {
return NewLiveIns.contains(SReg) && !MRI->isReserved(SReg);
}))
continue;
DebugLoc DL;
BuildMI(*Pred, InsertBefore, DL, TII->get(TargetOpcode::IMPLICIT_DEF),
Reg);

14
llvm/test/CodeGen/AMDGPU/branch-folding-implicit-def-subreg.ll
View File

@ -37,20 +37,10 @@ define amdgpu_kernel void @f1(ptr addrspace(1) %arg, ptr addrspace(1) %arg1, i64
; GFX90A-NEXT: renamable $sgpr34_sgpr35 = S_MOV_B64 0
; GFX90A-NEXT: renamable $vcc = S_AND_B64 $exec, renamable $sgpr30_sgpr31, implicit-def dead $scc
; GFX90A-NEXT: $vgpr24 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr24_lo16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr24_hi16 = IMPLICIT_DEF
; GFX90A-NEXT: $agpr0 = IMPLICIT_DEF
; GFX90A-NEXT: $agpr0_lo16 = IMPLICIT_DEF
; GFX90A-NEXT: $agpr0_hi16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr26_lo16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr26_hi16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr26 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr20 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr20_lo16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr20_hi16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr22 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr22_lo16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr22_hi16 = IMPLICIT_DEF
; GFX90A-NEXT: S_CBRANCH_VCCNZ %bb.58, implicit $vcc
; GFX90A-NEXT: {{ $}}
; GFX90A-NEXT: bb.2:
@ -583,11 +573,7 @@ define amdgpu_kernel void @f1(ptr addrspace(1) %arg, ptr addrspace(1) %arg1, i64
; GFX90A-NEXT: renamable $vgpr63, dead renamable $vcc = V_ADDC_U32_e64 0, $vgpr41, killed $vcc, 0, implicit $exec
; GFX90A-NEXT: renamable $vcc = S_AND_B64 $exec, renamable $sgpr48_sgpr49, implicit-def dead $scc
; GFX90A-NEXT: $agpr0 = IMPLICIT_DEF
; GFX90A-NEXT: $agpr0_lo16 = IMPLICIT_DEF
; GFX90A-NEXT: $agpr0_hi16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr14 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr14_lo16 = IMPLICIT_DEF
; GFX90A-NEXT: $vgpr14_hi16 = IMPLICIT_DEF
; GFX90A-NEXT: S_CBRANCH_VCCNZ %bb.48, implicit $vcc
; GFX90A-NEXT: {{ $}}
; GFX90A-NEXT: bb.44: