From 5be4536d091d7b927ceaa30a263ab5629f9008cc Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 14 Feb 2025 01:33:17 -0800 Subject: [PATCH] [clang-reorder-fields] Avoid repeated hash lookups (NFC) (#127165) --- .../clang-reorder-fields/ReorderFieldsAction.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp b/clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp index aeb7fe90f217..ea0207619fb2 100644 --- a/clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp +++ b/clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp @@ -70,11 +70,12 @@ getNewFieldsOrder(const RecordDecl *Definition, } SmallVector NewFieldsOrder; for (const auto &Name : DesiredFieldsOrder) { - if (!NameToIndex.count(Name)) { + auto It = NameToIndex.find(Name); + if (It == NameToIndex.end()) { llvm::errs() << "Field " << Name << " not found in definition.\n"; return {}; } - NewFieldsOrder.push_back(NameToIndex[Name]); + NewFieldsOrder.push_back(It->second); } assert(NewFieldsOrder.size() == NameToIndex.size()); return NewFieldsOrder;