mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-26 23:26:05 +00:00
Code Issues Projects Releases Wiki Activity

[analyzer] Fix a rare crash for valist check.

Browse Source 
It looks like on some host-triples the result of a valist related expr can be
a LazyCompoundVal. Handle that case in the check.

Patch by Abramo Bagnara!

llvm-svn: 297619
This commit is contained in:
Gabor Horvath 2017-03-13 12:48:26 +00:00
parent 345012dfa0
commit 60eec1ac1b
3 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp
View File

@ -165,11 +165,8 @@ void ValistChecker::checkPreCall(const CallEvent &Call,
const MemRegion *ValistChecker::getVAListAsRegion(SVal SV, const Expr *E,
bool &IsSymbolic,
CheckerContext &C) const {
// FIXME: on some platforms CallAndMessage checker finds some instances of
// the uninitialized va_list usages. CallAndMessage checker is disabled in
// the tests so they can verify platform independently those issues. As a
// side effect, this check is required here.
if (SV.isUnknownOrUndef())
const MemRegion *Reg = SV.getAsRegion();
if (!Reg)
return nullptr;
// TODO: In the future this should be abstracted away by the analyzer.
bool VaListModelledAsArray = false;
@ -178,7 +175,6 @@ const MemRegion *ValistChecker::getVAListAsRegion(SVal SV, const Expr *E,
VaListModelledAsArray =
Ty->isPointerType() && Ty->getPointeeType()->isRecordType();
}
const MemRegion *Reg = SV.getAsRegion();
if (const auto *DeclReg = Reg->getAs<DeclRegion>()) {
if (isa<ParmVarDecl>(DeclReg->getDecl()))
Reg = C.getState()->getSVal(SV.castAs<Loc>()).getAsRegion();

21
clang/test/Analysis/valist-as-lazycompound.c Normal file
View File

@ -0,0 +1,21 @@
// RUN: %clang_analyze_cc1 -triple gcc-linaro-arm-linux-gnueabihf -analyzer-checker=core,valist.Uninitialized,valist.CopyToSelf -analyzer-output=text -analyzer-store=region -verify %s
// expected-no-diagnostics
typedef unsigned int size_t;
typedef __builtin_va_list __gnuc_va_list;
typedef __gnuc_va_list va_list;
extern int vsprintf(char *__restrict __s,
const char *__restrict __format, __gnuc_va_list
__arg);
void _dprintf(const char *function, int flen, int line, int level,
const char *prefix, const char *fmt, ...) {
char raw[10];
int err;
va_list ap;
__builtin_va_start(ap, fmt);
err = vsprintf(raw, fmt, ap);
__builtin_va_end(ap);
}

2
clang/test/Analysis/valist-uninitialized-no-undef.c
View File

@ -1,4 +1,4 @@
// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -analyze -analyzer-checker=core,valist.Uninitialized,valist.CopyToSelf -analyzer-output=text -analyzer-store=region -verify %s
// RUN: %clang_analyze_cc1 -triple x86_64-pc-linux-gnu -analyzer-checker=core,valist.Uninitialized,valist.CopyToSelf -analyzer-output=text -analyzer-store=region -verify %s
#include "Inputs/system-header-simulator-for-valist.h"