mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-05-02 21:36:05 +00:00
Code Issues Projects Releases Wiki Activity

[ArgumentPromotion]: Copy function metadata after promoting arguments

Browse Source 
The argument promotion pass currently fails to copy function annotations
over to the modified function after promoting arguments.
This patch copies the original function annotation to the new function.

Reviewed By: fhann

Differential Revision: https://reviews.llvm.org/D86630
This commit is contained in:
Ettore Tiotto 2020-09-10 13:08:57 -04:00
parent 009cd4e491
commit 6b13cfe739
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
View File

@ -215,9 +215,11 @@ doPromotion(Function *F, SmallPtrSetImpl<Argument *> &ArgsToPromote,
Function *NF = Function::Create(NFTy, F->getLinkage(), F->getAddressSpace(),
F->getName());
NF->copyAttributesFrom(F);
NF->copyMetadata(F, 0);
// Patch the pointer to LLVM function in debug info descriptor.
NF->setSubprogram(F->getSubprogram());
// The new function will have the !dbg metadata copied from the original
// function. The original function may not be deleted, and dbg metadata need
// to be unique so we need to drop it.
F->setSubprogram(nullptr);
LLVM_DEBUG(dbgs() << "ARG PROMOTION: Promoting to:" << *NF << "\n"

5
llvm/test/Transforms/ArgumentPromotion/profile.ll
View File

@ -15,9 +15,9 @@ define void @caller() #0 {
ret void
}
define internal void @promote_i32_ptr(i32* %xp) {
define internal void @promote_i32_ptr(i32* %xp) !prof !1 {
; CHECK-LABEL: define {{[^@]+}}@promote_i32_ptr
; CHECK-SAME: (i32 [[XP_VAL:%.*]])
; CHECK-SAME: (i32 [[XP_VAL:%.*]]) !prof !1
; CHECK-NEXT: call void @use_i32(i32 [[XP_VAL]])
; CHECK-NEXT: ret void
;
@ -29,3 +29,4 @@ define internal void @promote_i32_ptr(i32* %xp) {
declare void @use_i32(i32)
!0 = !{!"branch_weights", i32 30}
!1 = !{!"function_entry_count", i64 100}