From 785e7f06ddb1ba36aa679d23436726dcf61f8afb Mon Sep 17 00:00:00 2001 From: Michael Kruse Date: Thu, 10 Apr 2025 11:18:51 +0200 Subject: [PATCH] Remember LLVM_ENABLE_LIBCXX setting in installed configuration (#134990) The buidbot [flang-aarch64-libcxx](https://lab.llvm.org/buildbot/#/builders/89) is currently failing with an ABI issue. The suspected reason is that LLVMSupport.a is built using libc++, but the unittests are using the default C++ standard library, libstdc++ in this case. This predefined `llvm_gtest` target uses the LLVMSupport from `find_package(LLVM)`, which finds the libc++-built LLVMSupport. To fix, store the `LLVM_ENABLE_LIBCXX` setting in the LLVMConfig.cmake such that everything that links to LLVM libraries use the same standard library. In this case discussed in https://github.com/llvm/llvm-zorg/pull/387 it was the flang-rt unittests, but other runtimes with GTest unittests should have the same issue (e.g. offload), and any external project that uses `find_package(LLVM)`. --- llvm/cmake/modules/LLVMConfig.cmake.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/llvm/cmake/modules/LLVMConfig.cmake.in b/llvm/cmake/modules/LLVMConfig.cmake.in index 5ccc66b8039b..1c34073f6b91 100644 --- a/llvm/cmake/modules/LLVMConfig.cmake.in +++ b/llvm/cmake/modules/LLVMConfig.cmake.in @@ -55,6 +55,8 @@ endif() set(LLVM_ENABLE_RTTI @LLVM_ENABLE_RTTI@) +set(LLVM_ENABLE_LIBCXX @LLVM_ENABLE_LIBCXX@) + set(LLVM_ENABLE_LIBEDIT @HAVE_LIBEDIT@) if(LLVM_ENABLE_LIBEDIT) find_package(LibEdit)