mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-25 06:26:06 +00:00
Code Issues Projects Releases Wiki Activity

Revert "[CMake][LIT] Add option to run lit testsuites in parallel" (#84813)

Browse Source 
Reverts llvm/llvm-project#82899

Per the discussion on the PR, this needs more design and justification.
This commit is contained in:
Jeff Niu 2024-03-11 11:44:11 -07:00 committed by GitHub
parent 5b4c350647
commit 8846b91e15
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/CMakeLists.txt
View File

@ -712,8 +712,6 @@ if(LLVM_INDIVIDUAL_TEST_COVERAGE)
endif()
set(LLVM_LIT_ARGS "${LIT_ARGS_DEFAULT}" CACHE STRING "Default options for lit")
option(LLVM_PARALLEL_LIT "Enable multiple lit suites to run in parallel" OFF)
# On Win32 hosts, provide an option to specify the path to the GnuWin32 tools.
if( WIN32 AND NOT CYGWIN )
set(LLVM_LIT_TOOLS_DIR "" CACHE PATH "Path to GnuWin32 tools")

17
llvm/cmake/modules/AddLLVM.cmake
View File

@ -1947,18 +1947,11 @@ function(add_lit_target target comment)
list(APPEND LIT_COMMAND --param ${param})
endforeach()
if (ARG_UNPARSED_ARGUMENTS)
if (LLVM_PARALLEL_LIT)
add_custom_target(${target}
COMMAND ${LIT_COMMAND} ${ARG_UNPARSED_ARGUMENTS}
COMMENT "${comment}"
)
else()
add_custom_target(${target}
COMMAND ${LIT_COMMAND} ${ARG_UNPARSED_ARGUMENTS}
COMMENT "${comment}"
USES_TERMINAL
)
endif()
add_custom_target(${target}
COMMAND ${LIT_COMMAND} ${ARG_UNPARSED_ARGUMENTS}
COMMENT "${comment}"
USES_TERMINAL
)
else()
add_custom_target(${target}
COMMAND ${CMAKE_COMMAND} -E echo "${target} does nothing, no tools built.")

6
llvm/docs/CMake.rst
View File

@ -762,12 +762,6 @@ enabled sub-projects. Nearly all of these variable names begin with
**LLVM_PARALLEL_LINK_JOBS**:STRING
Define the maximum number of concurrent link jobs.
**LLVM_PARALLEL_LIT**:BOOL
Defaults to ``OFF``. If set to ``OFF``, lit testsuites will be configured
with CMake's ``USES_TERMINAL`` flag to give direct access to the terminal. If
set to ``ON``, that flag will be removed allowing Ninja to schedule multiple
lit testsuites in parallel.
**LLVM_RAM_PER_COMPILE_JOB**:STRING
Calculates the amount of Ninja compile jobs according to available resources.
Value has to be in MB, overwrites LLVM_PARALLEL_COMPILE_JOBS. Compile jobs