From 888969f62abe6df9c9bafd593a6ba345577198b3 Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Fri, 30 Oct 2020 11:36:27 +0000 Subject: [PATCH] [clangd] Fix MSVC implicit capture build failure. MSVC builds were failing because the constexpr wasn't couldn't be captured by the lamdba. Fix an implicit double to float truncation warning as well. --- clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp b/clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp index b2534bdf9c19..a7e1c6c48143 100644 --- a/clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp +++ b/clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp @@ -196,10 +196,10 @@ TEST(DecisionForestRankingModel, ReferencesAffectRanking) { TEST(DecisionForestRankingModel, DecisionForestScorerCallbackTest) { clangd::CodeCompleteOptions Opts; - constexpr float MagicNumber = 1234.5678; + constexpr float MagicNumber = 1234.5678f; Opts.RankingModel = CodeCompleteOptions::DecisionForest; - Opts.DecisionForestScorer = [](const SymbolQualitySignals &, - const SymbolRelevanceSignals &, float Base) { + Opts.DecisionForestScorer = [&](const SymbolQualitySignals &, + const SymbolRelevanceSignals &, float Base) { DecisionForestScores Scores; Scores.Total = MagicNumber; Scores.ExcludingName = MagicNumber;