mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-16 14:46:36 +00:00
Code Issues Projects Releases Wiki Activity

[LLD][COFF] Add /inferasanlibs to lld-link as ignored flag

Browse Source 
MSVC link.exe added this flag and MS STL started using this flag in
.drectve [1] when compiling with Clang with asan enabled, as reported
on https://github.com/llvm/llvm-project/issues/56300. This causes issues
with lld-link because it rejects any unknown flags in .drective sections.

As dc07867dc9991c982bd3441da19d6fcc16ea54d6 noted that, when using Clang
as the driver it explicitly passes the proper asan libraries. Therefore
it should be acceptable to ignore this flag in lld-link to at least
unbreak building with clang-cl and linking with lld-link.

[1]: faaf094ee1/stl/inc/__msvc_sanitizer_annotate_container.hpp (L35)

Differential Revision: https://reviews.llvm.org/D149023
This commit is contained in:
Alvin Wong 2023-04-23 23:58:24 +08:00
parent 9b15e9840f
commit 8fa0cfeb61
4 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lld/COFF/Driver.cpp
View File

@ -445,6 +445,8 @@ void LinkerDriver::parseDirectives(InputFile *file) {
case OPT_editandcontinue:
case OPT_guardsym:
case OPT_throwingnew:
case OPT_inferasanlibs:
case OPT_inferasanlibs_no:
break;
default:
error(arg->getSpelling() + " is not allowed in .drectve (" +
@ -1933,6 +1935,9 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
args.hasFlag(OPT_stdcall_fixup, OPT_stdcall_fixup_no, config->mingw);
config->warnStdcallFixup = !args.hasArg(OPT_stdcall_fixup);
if (args.hasFlag(OPT_inferasanlibs, OPT_inferasanlibs_no, false))
warn("ignoring '/inferasanlibs', this flag is not supported");
// Don't warn about long section names, such as .debug_info, for mingw or
// when -debug:dwarf is requested.
if (config->mingw || config->debugDwarf)

3
lld/COFF/Options.td
View File

@ -194,6 +194,9 @@ defm highentropyva : B<"highentropyva",
defm incremental : B<"incremental",
"Keep original import library if contents are unchanged",
"Overwrite import library even if contents are unchanged">;
defm inferasanlibs : B<"inferasanlibs",
"Unused, generates a warning",
"No effect (default)">;
defm integritycheck : B<"integritycheck",
"Set FORCE_INTEGRITY bit in PE header",
"No effect (default)">;

16
lld/test/COFF/inferasanlibs-drectve.s Normal file
View File

@ -0,0 +1,16 @@
# REQUIRES: x86
# RUN: llvm-mc -triple=x86_64-windows %s -filetype=obj -o %t.obj
# RUN: lld-link -dll -out:%t.dll -entry:entry %t.obj -subsystem:console 2>&1 | FileCheck --allow-empty --ignore-case %s
# CHECK-NOT: ignoring unknown argument
# CHECK-NOT: inferasanlibs
# CHECK-NOT: is not allowed in .drectve
.global entry
.text
entry:
ret
.section .drectve
.ascii " /INFERASANLIBS "

8
lld/test/COFF/inferasanlibs.test Normal file
View File

@ -0,0 +1,8 @@
# RUN: yaml2obj %p/Inputs/ret42.yaml -o %t.obj
# RUN: lld-link /out:%t.exe /entry:main %t.obj /inferasanlibs 2>&1 | FileCheck --check-prefix=POS %s
# RUN: lld-link /out:%t.exe /entry:main %t.obj /inferasanlibs:no 2>&1 | FileCheck --allow-empty --check-prefix=NEG %s
POS: ignoring '/inferasanlibs', this flag is not supported
NEG-NOT: ignoring '/inferasanlibs', this flag is not supported