mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-26 09:16:08 +00:00
Code Issues Projects Releases Wiki Activity

[rtsan] Remove mkfifoat interceptor (#116997)

Browse Source 
This partially reverts #116915
[fce917d](fce917d39d)

mkfifoat was improperly guarded against in MacOS systems
This commit is contained in:
Chris Apple 2024-11-20 08:27:58 -08:00 committed by GitHub
parent b8e1d4dbea
commit 934140a335
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
View File

@ -746,16 +746,6 @@ INTERCEPTOR(int, mkfifo, const char *pathname, mode_t mode) {
return REAL(mkfifo)(pathname, mode);
}
// see comment above about -Wunguarded-availability-new
// and why we disable it here
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunguarded-availability-new"
INTERCEPTOR(int, mkfifoat, int dirfd, const char *pathname, mode_t mode) {
__rtsan_notify_intercepted_call("mkfifoat");
return REAL(mkfifoat)(dirfd, pathname, mode);
}
#pragma clang diagnostic pop
// Preinit
void __rtsan::InitializeInterceptors() {
INTERCEPT_FUNCTION(calloc);
@ -859,7 +849,6 @@ void __rtsan::InitializeInterceptors() {
INTERCEPT_FUNCTION(pipe);
INTERCEPT_FUNCTION(mkfifo);
INTERCEPT_FUNCTION(mkfifoat);
}
#endif // SANITIZER_POSIX

15
compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
View File

@ -971,21 +971,6 @@ TEST(TestRtsanInterceptors, MkfifoDiesWhenRealtime) {
ExpectNonRealtimeSurvival(Func);
}
#if __has_builtin(__builtin_available) && SANITIZER_APPLE
#define MKFIFOAT_AVAILABLE() (__builtin_available(macOS 10.13, *))
#else
// We are going to assume this is true until we hit systems where it isn't
#define MKFIFOAT_AVAILABLE() (true)
#endif
TEST(TestRtsanInterceptors, MkfifoatDiesWhenRealtime) {
if (MKFIFOAT_AVAILABLE()) {
auto Func = []() { mkfifoat(0, "/tmp/rtsan_test_fifo", 0); };
ExpectRealtimeDeath(Func, "mkfifoat");
ExpectNonRealtimeSurvival(Func);
}
}
TEST(TestRtsanInterceptors, PipeDiesWhenRealtime) {
int fds[2];
auto Func = [&fds]() { pipe(fds); };