mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-25 18:26:06 +00:00
Code Issues Projects Releases Wiki Activity

[MLGO] Fix logging verbosity in scripts (#107818)

Browse Source 
This patch fixes issues related to logging verbosity in the MLGO python
scripts. This was an oversight when converting from absl.logging to the
python logging API as absl natively supports a --verbosity flag to set
the desired logging level. This patch adds a flag to support similar
functionality in Python's logging library and additionally updates
docstrings where relevant to point to the new values.
This commit is contained in:
Aiden Grossman 2024-09-09 11:34:53 -07:00 committed by GitHub
parent a7c26aaf2e
commit 99ea357f7b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/utils/mlgo-utils/mlgo/corpus/combine_training_corpus.py
View File

@ -24,6 +24,7 @@ and corpus2 are combined into combinedcorpus.
"""
import argparse
import logging
from mlgo.corpus import combine_training_corpus_lib
@ -35,11 +36,22 @@ def parse_args_and_run():
parser.add_argument(
"--root_dir", type=str, help="The root dir of module paths to combine."
)
# TODO(#107898): Refactor this into a common location.
parser.add_argument(
"--verbosity",
type=str,
help="The verbosity level to use for logging",
default="INFO",
nargs="?",
choices=["DEBUG", "INFO", "WARNING", "ERROR"],
)
args = parser.parse_args()
main(args)
def main(args):
logging.basicConfig(level=args.verbosity)
combine_training_corpus_lib.combine_corpus(args.root_dir)

18
llvm/utils/mlgo-utils/mlgo/corpus/extract_ir.py
View File

@ -18,10 +18,9 @@ specifying -mllvm -lto-embed-bitcode=post-merge-pre-opt.
In a local ThinLTO case, the compilation is assumedto have been performed
specifying -Wl,--save-temps=import -Wl,--thinlto-emit-index-files
To change the logging verbosity, pass an integer representing the desired
verbosity to the --verbosity flag. Use 0 for all logs, status information,
and detailed debug information, -1 for solely warnings, and -2 to not produce
any output.
To change the logging verbosity, set the --verbosity flag to the desired level.
Setting it to a specific level will enable all messages at that level and
higher. Exact values can be found by invoking the script with --help.
"""
import argparse
@ -112,11 +111,22 @@ def parse_args_and_run():
default=".llvmbc",
nargs="?",
)
# TODO(#107898): Refactor this into a common location.
parser.add_argument(
"--verbosity",
type=str,
help="The verbosity level to use for logging",
default="INFO",
nargs="?",
choices=["DEBUG", "INFO", "WARNING", "ERROR"],
)
args = parser.parse_args()
main(args)
def main(args):
logging.basicConfig(level=args.verbosity)
objs = []
if args.input is not None and args.thinlto_build == "local":
raise ValueError("--thinlto_build=local cannot be run with --input")