diff --git a/clang/include/clang/AST/ExprObjC.h b/clang/include/clang/AST/ExprObjC.h index a75e1e3edda7..1070a11eb3b9 100644 --- a/clang/include/clang/AST/ExprObjC.h +++ b/clang/include/clang/AST/ExprObjC.h @@ -257,7 +257,7 @@ public: virtual child_iterator child_end(); }; -/// ObjCImplctSetterGetterRefExpr - A dot-syntax expression to access two +/// ObjCImplicitSetterGetterRefExpr - A dot-syntax expression to access two /// methods; one to set a value to an 'ivar' (Setter) and the other to access /// an 'ivar' (Setter). /// An example for use of this AST is: @@ -268,38 +268,42 @@ public: /// @end /// void foo(Test *p1, Test *p2) /// { -/// p2.crash = p1.crash; // Uses ObjCImplctSetterGetterRefExpr AST +/// p2.crash = p1.crash; // Uses ObjCImplicitSetterGetterRefExpr AST /// } /// @endcode -class ObjCImplctSetterGetterRefExpr : public Expr { +class ObjCImplicitSetterGetterRefExpr : public Expr { /// Setter - Setter method user declared for setting its 'ivar' to a value ObjCMethodDecl *Setter; /// Getter - Getter method user declared for accessing 'ivar' it controls. ObjCMethodDecl *Getter; - SourceLocation Loc; + /// Location of the member in the dot syntax notation. This is location + /// of the getter method. + SourceLocation MemberLoc; // FIXME: Swizzle these into a single pointer. Stmt *Base; ObjCInterfaceDecl *InterfaceDecl; + /// Location of the receiver class in the dot syntax notation + /// used to call a class method setter/getter. SourceLocation ClassLoc; public: - ObjCImplctSetterGetterRefExpr(ObjCMethodDecl *getter, + ObjCImplicitSetterGetterRefExpr(ObjCMethodDecl *getter, QualType t, ObjCMethodDecl *setter, SourceLocation l, Expr *base) - : Expr(ObjCImplctSetterGetterRefExprClass, t), Setter(setter), - Getter(getter), Loc(l), Base(base), InterfaceDecl(0), + : Expr(ObjCImplicitSetterGetterRefExprClass, t), Setter(setter), + Getter(getter), MemberLoc(l), Base(base), InterfaceDecl(0), ClassLoc(SourceLocation()) { } - ObjCImplctSetterGetterRefExpr(ObjCMethodDecl *getter, + ObjCImplicitSetterGetterRefExpr(ObjCMethodDecl *getter, QualType t, ObjCMethodDecl *setter, SourceLocation l, ObjCInterfaceDecl *C, SourceLocation CL) - : Expr(ObjCImplctSetterGetterRefExprClass, t), Setter(setter), - Getter(getter), Loc(l), Base(0), InterfaceDecl(C), ClassLoc(CL) { + : Expr(ObjCImplicitSetterGetterRefExprClass, t), Setter(setter), + Getter(getter), MemberLoc(l), Base(0), InterfaceDecl(C), ClassLoc(CL) { } - explicit ObjCImplctSetterGetterRefExpr(EmptyShell Empty) - : Expr(ObjCImplctSetterGetterRefExprClass, Empty){} + explicit ObjCImplicitSetterGetterRefExpr(EmptyShell Empty) + : Expr(ObjCImplicitSetterGetterRefExprClass, Empty){} ObjCMethodDecl *getGetterMethod() const { return Getter; } ObjCMethodDecl *getSetterMethod() const { return Setter; } @@ -310,22 +314,22 @@ public: virtual SourceRange getSourceRange() const { if (Base) - return SourceRange(getBase()->getLocStart(), Loc); - return SourceRange(ClassLoc, Loc); + return SourceRange(getBase()->getLocStart(), MemberLoc); + return SourceRange(ClassLoc, MemberLoc); } const Expr *getBase() const { return cast_or_null(Base); } Expr *getBase() { return cast_or_null(Base); } void setBase(Expr *base) { Base = base; } - SourceLocation getLocation() const { return Loc; } - void setLocation(SourceLocation L) { Loc = L; } + SourceLocation getLocation() const { return MemberLoc; } + void setLocation(SourceLocation L) { MemberLoc = L; } SourceLocation getClassLoc() const { return ClassLoc; } void setClassLoc(SourceLocation L) { ClassLoc = L; } static bool classof(const Stmt *T) { - return T->getStmtClass() == ObjCImplctSetterGetterRefExprClass; + return T->getStmtClass() == ObjCImplicitSetterGetterRefExprClass; } - static bool classof(const ObjCImplctSetterGetterRefExpr *) { return true; } + static bool classof(const ObjCImplicitSetterGetterRefExpr *) { return true; } // Iterators virtual child_iterator child_begin(); diff --git a/clang/include/clang/AST/StmtNodes.def b/clang/include/clang/AST/StmtNodes.def index ebbeba2ac25a..af345991f1e6 100644 --- a/clang/include/clang/AST/StmtNodes.def +++ b/clang/include/clang/AST/StmtNodes.def @@ -144,7 +144,7 @@ EXPR(ObjCSelectorExpr , Expr) EXPR(ObjCProtocolExpr , Expr) EXPR(ObjCIvarRefExpr , Expr) EXPR(ObjCPropertyRefExpr , Expr) -EXPR(ObjCImplctSetterGetterRefExpr , Expr) +EXPR(ObjCImplicitSetterGetterRefExpr , Expr) EXPR(ObjCSuperExpr , Expr) EXPR(ObjCIsaExpr , Expr) diff --git a/clang/include/clang/Frontend/PCHBitCodes.h b/clang/include/clang/Frontend/PCHBitCodes.h index f4284e9c5c8b..6e2e8c451196 100644 --- a/clang/include/clang/Frontend/PCHBitCodes.h +++ b/clang/include/clang/Frontend/PCHBitCodes.h @@ -636,7 +636,7 @@ namespace clang { EXPR_OBJC_IVAR_REF_EXPR, /// \brief An ObjCPropertyRefExpr record. EXPR_OBJC_PROPERTY_REF_EXPR, - /// \brief An ObjCImplctSetterGetterRefExpr record. + /// \brief An ObjCImplicitSetterGetterRefExpr record. EXPR_OBJC_KVC_REF_EXPR, /// \brief An ObjCMessageExpr record. EXPR_OBJC_MESSAGE_EXPR, diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp index 225f17790317..7cc436c7a901 100644 --- a/clang/lib/AST/Expr.cpp +++ b/clang/lib/AST/Expr.cpp @@ -542,10 +542,10 @@ bool Expr::isUnusedResultAWarning(SourceLocation &Loc, SourceRange &R1, case ObjCMessageExprClass: return false; - case ObjCImplctSetterGetterRefExprClass: { // Dot syntax for message send. + case ObjCImplicitSetterGetterRefExprClass: { // Dot syntax for message send. #if 0 - const ObjCImplctSetterGetterRefExpr *Ref = - cast(this); + const ObjCImplicitSetterGetterRefExpr *Ref = + cast(this); // FIXME: We really want the location of the '.' here. Loc = Ref->getLocation(); R1 = SourceRange(Ref->getLocation(), Ref->getLocation()); @@ -794,7 +794,7 @@ Expr::isLvalueResult Expr::isLvalueInternal(ASTContext &Ctx) const { return LV_Valid; case ObjCPropertyRefExprClass: // FIXME: check if read-only property. return LV_Valid; - case ObjCImplctSetterGetterRefExprClass: // FIXME: check if read-only property. + case ObjCImplicitSetterGetterRefExprClass: // FIXME: check if read-only property. return LV_Valid; case PredefinedExprClass: return LV_Valid; @@ -915,9 +915,9 @@ Expr::isModifiableLvalue(ASTContext &Ctx, SourceLocation *Loc) const { } // Assigning to an 'implicit' property? - else if (isa(this)) { - const ObjCImplctSetterGetterRefExpr* Expr = - cast(this); + else if (isa(this)) { + const ObjCImplicitSetterGetterRefExpr* Expr = + cast(this); if (Expr->getSetterMethod() == 0) return MLV_NoSetterProperty; } @@ -1863,11 +1863,11 @@ Stmt::child_iterator ObjCIvarRefExpr::child_end() { return &Base+1; } Stmt::child_iterator ObjCPropertyRefExpr::child_begin() { return &Base; } Stmt::child_iterator ObjCPropertyRefExpr::child_end() { return &Base+1; } -// ObjCImplctSetterGetterRefExpr -Stmt::child_iterator ObjCImplctSetterGetterRefExpr::child_begin() { +// ObjCImplicitSetterGetterRefExpr +Stmt::child_iterator ObjCImplicitSetterGetterRefExpr::child_begin() { return &Base; } -Stmt::child_iterator ObjCImplctSetterGetterRefExpr::child_end() { +Stmt::child_iterator ObjCImplicitSetterGetterRefExpr::child_end() { return &Base+1; } diff --git a/clang/lib/AST/StmtDumper.cpp b/clang/lib/AST/StmtDumper.cpp index 6a48d5a47b52..ff6d225cdb9b 100644 --- a/clang/lib/AST/StmtDumper.cpp +++ b/clang/lib/AST/StmtDumper.cpp @@ -148,8 +148,8 @@ namespace { void VisitObjCSelectorExpr(ObjCSelectorExpr *Node); void VisitObjCProtocolExpr(ObjCProtocolExpr *Node); void VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *Node); - void VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *Node); + void VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *Node); void VisitObjCIvarRefExpr(ObjCIvarRefExpr *Node); void VisitObjCSuperExpr(ObjCSuperExpr *Node); }; @@ -522,8 +522,8 @@ void StmtDumper::VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *Node) { Node->getProperty()->getNameAsString().c_str()); } -void StmtDumper::VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *Node) { +void StmtDumper::VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *Node) { DumpExpr(Node); ObjCMethodDecl *Getter = Node->getGetterMethod(); diff --git a/clang/lib/AST/StmtPrinter.cpp b/clang/lib/AST/StmtPrinter.cpp index 9b8dfce00e7d..36464ca3961b 100644 --- a/clang/lib/AST/StmtPrinter.cpp +++ b/clang/lib/AST/StmtPrinter.cpp @@ -518,8 +518,8 @@ void StmtPrinter::VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *Node) { OS << Node->getProperty()->getNameAsCString(); } -void StmtPrinter::VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *Node) { +void StmtPrinter::VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *Node) { if (Node->getBase()) { PrintExpr(Node->getBase()); OS << "."; diff --git a/clang/lib/AST/StmtProfile.cpp b/clang/lib/AST/StmtProfile.cpp index 1feee3880a6c..ff2029916843 100644 --- a/clang/lib/AST/StmtProfile.cpp +++ b/clang/lib/AST/StmtProfile.cpp @@ -583,8 +583,8 @@ void StmtProfiler::VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *S) { VisitDecl(S->getProperty()); } -void StmtProfiler::VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *S) { +void StmtProfiler::VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *S) { VisitExpr(S); VisitDecl(S->getGetterMethod()); VisitDecl(S->getSetterMethod()); diff --git a/clang/lib/Analysis/GRExprEngine.cpp b/clang/lib/Analysis/GRExprEngine.cpp index c59dafc11b03..487b9764ce26 100644 --- a/clang/lib/Analysis/GRExprEngine.cpp +++ b/clang/lib/Analysis/GRExprEngine.cpp @@ -528,7 +528,7 @@ void GRExprEngine::VisitLValue(Expr* Ex, ExplodedNode* Pred, return; case Stmt::ObjCPropertyRefExprClass: - case Stmt::ObjCImplctSetterGetterRefExprClass: + case Stmt::ObjCImplicitSetterGetterRefExprClass: // FIXME: Property assignments are lvalues, but not really "locations". // e.g.: self.x = something; // Here the "self.x" really can translate to a method call (setter) when @@ -2787,8 +2787,8 @@ void GRExprEngine::VisitBinaryOperator(BinaryOperator* B, Expr* LHS = B->getLHS()->IgnoreParens(); Expr* RHS = B->getRHS()->IgnoreParens(); - // FIXME: Add proper support for ObjCImplctSetterGetterRefExpr. - if (isa(LHS)) { + // FIXME: Add proper support for ObjCImplicitSetterGetterRefExpr. + if (isa(LHS)) { Visit(RHS, Pred, Dst); return; } diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp index 3f07909ea5fb..310fae03c632 100644 --- a/clang/lib/CodeGen/CGExpr.cpp +++ b/clang/lib/CodeGen/CGExpr.cpp @@ -227,8 +227,8 @@ LValue CodeGenFunction::EmitLValue(const Expr *E) { return EmitObjCIvarRefLValue(cast(E)); case Expr::ObjCPropertyRefExprClass: return EmitObjCPropertyRefLValue(cast(E)); - case Expr::ObjCImplctSetterGetterRefExprClass: - return EmitObjCKVCRefLValue(cast(E)); + case Expr::ObjCImplicitSetterGetterRefExprClass: + return EmitObjCKVCRefLValue(cast(E)); case Expr::ObjCSuperExprClass: return EmitObjCSuperExprLValue(cast(E)); @@ -1026,7 +1026,7 @@ LValue CodeGenFunction::EmitMemberExpr(const MemberExpr *E) { isUnion = true; CVRQualifiers = PTy->getPointeeType().getCVRQualifiers(); } else if (isa(BaseExpr) || - isa(BaseExpr)) { + isa(BaseExpr)) { RValue RV = EmitObjCPropertyGet(BaseExpr); BaseValue = RV.getAggregateAddr(); if (BaseExpr->getType()->isUnionType()) @@ -1342,7 +1342,7 @@ CodeGenFunction::EmitObjCPropertyRefLValue(const ObjCPropertyRefExpr *E) { LValue CodeGenFunction::EmitObjCKVCRefLValue( - const ObjCImplctSetterGetterRefExpr *E) { + const ObjCImplicitSetterGetterRefExpr *E) { // This is a special l-value that just issues sends when we load or // store through it. return LValue::MakeKVCRef(E, E->getType().getCVRQualifiers()); diff --git a/clang/lib/CodeGen/CGExprAgg.cpp b/clang/lib/CodeGen/CGExprAgg.cpp index 1c1fc9b4513d..6f6daa79d0c7 100644 --- a/clang/lib/CodeGen/CGExprAgg.cpp +++ b/clang/lib/CodeGen/CGExprAgg.cpp @@ -99,7 +99,7 @@ public: EmitAggLoadOfLValue(E); } void VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *E); - void VisitObjCImplctSetterGetterRefExpr(ObjCImplctSetterGetterRefExpr *E); + void VisitObjCImplicitSetterGetterRefExpr(ObjCImplicitSetterGetterRefExpr *E); void VisitConditionalOperator(const ConditionalOperator *CO); void VisitChooseExpr(const ChooseExpr *CE); @@ -208,8 +208,8 @@ void AggExprEmitter::VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *E) { EmitFinalDestCopy(E, RV); } -void AggExprEmitter::VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *E) { +void AggExprEmitter::VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *E) { RValue RV = CGF.EmitObjCPropertyGet(E); EmitFinalDestCopy(E, RV); } diff --git a/clang/lib/CodeGen/CGExprComplex.cpp b/clang/lib/CodeGen/CGExprComplex.cpp index ab8ccfbdbfc6..f9cb607611de 100644 --- a/clang/lib/CodeGen/CGExprComplex.cpp +++ b/clang/lib/CodeGen/CGExprComplex.cpp @@ -120,8 +120,8 @@ public: ComplexPairTy VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *E) { return EmitLoadOfLValue(E); } - ComplexPairTy VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *E) { + ComplexPairTy VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *E) { return EmitLoadOfLValue(E); } ComplexPairTy VisitObjCMessageExpr(ObjCMessageExpr *E) { diff --git a/clang/lib/CodeGen/CGExprScalar.cpp b/clang/lib/CodeGen/CGExprScalar.cpp index 5650ed742591..bd005943a202 100644 --- a/clang/lib/CodeGen/CGExprScalar.cpp +++ b/clang/lib/CodeGen/CGExprScalar.cpp @@ -158,8 +158,8 @@ public: Value *VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *E) { return EmitLoadOfLValue(E); } - Value *VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *E) { + Value *VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *E) { return EmitLoadOfLValue(E); } Value *VisitObjCMessageExpr(ObjCMessageExpr *E) { diff --git a/clang/lib/CodeGen/CGObjC.cpp b/clang/lib/CodeGen/CGObjC.cpp index 82bac9ac574f..1c1b303e0829 100644 --- a/clang/lib/CodeGen/CGObjC.cpp +++ b/clang/lib/CodeGen/CGObjC.cpp @@ -337,8 +337,8 @@ RValue CodeGenFunction::EmitObjCPropertyGet(const Expr *Exp) { EmitScalarExpr(E->getBase()), false, CallArgList()); } else { - const ObjCImplctSetterGetterRefExpr *KE = - cast(Exp); + const ObjCImplicitSetterGetterRefExpr *KE = + cast(Exp); Selector S = KE->getGetterMethod()->getSelector(); llvm::Value *Receiver; if (KE->getInterfaceDecl()) { @@ -389,8 +389,8 @@ void CodeGenFunction::EmitObjCPropertySet(const Expr *Exp, CGM.getObjCRuntime().GenerateMessageSend(*this, getContext().VoidTy, S, EmitScalarExpr(E->getBase()), false, Args); - } else if (const ObjCImplctSetterGetterRefExpr *E = - dyn_cast(Exp)) { + } else if (const ObjCImplicitSetterGetterRefExpr *E = + dyn_cast(Exp)) { Selector S = E->getSetterMethod()->getSelector(); CallArgList Args; llvm::Value *Receiver; diff --git a/clang/lib/CodeGen/CGValue.h b/clang/lib/CodeGen/CGValue.h index 15020e915760..5aaf951a542d 100644 --- a/clang/lib/CodeGen/CGValue.h +++ b/clang/lib/CodeGen/CGValue.h @@ -24,7 +24,7 @@ namespace llvm { namespace clang { class ObjCPropertyRefExpr; - class ObjCImplctSetterGetterRefExpr; + class ObjCImplicitSetterGetterRefExpr; namespace CodeGen { @@ -143,7 +143,7 @@ class LValue { // Obj-C property reference expression const ObjCPropertyRefExpr *PropertyRefExpr; // ObjC 'implicit' property reference expression - const ObjCImplctSetterGetterRefExpr *KVCRefExpr; + const ObjCImplicitSetterGetterRefExpr *KVCRefExpr; }; bool Volatile:1; @@ -251,7 +251,7 @@ public: } // 'implicit' property ref lvalue - const ObjCImplctSetterGetterRefExpr *getKVCRefExpr() const { + const ObjCImplicitSetterGetterRefExpr *getKVCRefExpr() const { assert(isKVCRef()); return KVCRefExpr; } @@ -313,7 +313,7 @@ public: return R; } - static LValue MakeKVCRef(const ObjCImplctSetterGetterRefExpr *E, + static LValue MakeKVCRef(const ObjCImplicitSetterGetterRefExpr *E, unsigned Qualifiers) { LValue R; R.LVType = KVCRef; diff --git a/clang/lib/CodeGen/CodeGenFunction.h b/clang/lib/CodeGen/CodeGenFunction.h index 4d176a49462e..b4cbc965d54d 100644 --- a/clang/lib/CodeGen/CodeGenFunction.h +++ b/clang/lib/CodeGen/CodeGenFunction.h @@ -787,7 +787,7 @@ public: LValue EmitObjCMessageExprLValue(const ObjCMessageExpr *E); LValue EmitObjCIvarRefLValue(const ObjCIvarRefExpr *E); LValue EmitObjCPropertyRefLValue(const ObjCPropertyRefExpr *E); - LValue EmitObjCKVCRefLValue(const ObjCImplctSetterGetterRefExpr *E); + LValue EmitObjCKVCRefLValue(const ObjCImplicitSetterGetterRefExpr *E); LValue EmitObjCSuperExprLValue(const ObjCSuperExpr *E); LValue EmitStmtExprLValue(const StmtExpr *E); diff --git a/clang/lib/Frontend/PCHReaderStmt.cpp b/clang/lib/Frontend/PCHReaderStmt.cpp index f39d96114701..fdefec78ad35 100644 --- a/clang/lib/Frontend/PCHReaderStmt.cpp +++ b/clang/lib/Frontend/PCHReaderStmt.cpp @@ -101,8 +101,8 @@ namespace { unsigned VisitObjCProtocolExpr(ObjCProtocolExpr *E); unsigned VisitObjCIvarRefExpr(ObjCIvarRefExpr *E); unsigned VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *E); - unsigned VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *E); + unsigned VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *E); unsigned VisitObjCMessageExpr(ObjCMessageExpr *E); unsigned VisitObjCSuperExpr(ObjCSuperExpr *E); unsigned VisitObjCIsaExpr(ObjCIsaExpr *E); @@ -742,8 +742,8 @@ unsigned PCHStmtReader::VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *E) { return 1; } -unsigned PCHStmtReader::VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *E) { +unsigned PCHStmtReader::VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *E) { VisitExpr(E); E->setGetterMethod( cast_or_null(Reader.GetDecl(Record[Idx++]))); @@ -1116,7 +1116,7 @@ Stmt *PCHReader::ReadStmt(llvm::BitstreamCursor &Cursor) { S = new (Context) ObjCPropertyRefExpr(Empty); break; case pch::EXPR_OBJC_KVC_REF_EXPR: - S = new (Context) ObjCImplctSetterGetterRefExpr(Empty); + S = new (Context) ObjCImplicitSetterGetterRefExpr(Empty); break; case pch::EXPR_OBJC_MESSAGE_EXPR: S = new (Context) ObjCMessageExpr(Empty); diff --git a/clang/lib/Frontend/PCHWriterStmt.cpp b/clang/lib/Frontend/PCHWriterStmt.cpp index 63d3dbff0cb3..d62a8154c50a 100644 --- a/clang/lib/Frontend/PCHWriterStmt.cpp +++ b/clang/lib/Frontend/PCHWriterStmt.cpp @@ -94,8 +94,8 @@ namespace { void VisitObjCProtocolExpr(ObjCProtocolExpr *E); void VisitObjCIvarRefExpr(ObjCIvarRefExpr *E); void VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *E); - void VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *E); + void VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *E); void VisitObjCMessageExpr(ObjCMessageExpr *E); void VisitObjCSuperExpr(ObjCSuperExpr *E); void VisitObjCIsaExpr(ObjCIsaExpr *E); @@ -673,8 +673,8 @@ void PCHStmtWriter::VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *E) { Code = pch::EXPR_OBJC_PROPERTY_REF_EXPR; } -void PCHStmtWriter::VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *E) { +void PCHStmtWriter::VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *E) { VisitExpr(E); Writer.AddDeclRef(E->getGetterMethod(), Record); Writer.AddDeclRef(E->getSetterMethod(), Record); diff --git a/clang/lib/Frontend/StmtXML.cpp b/clang/lib/Frontend/StmtXML.cpp index 7f7b59b68073..b6d04810bfa1 100644 --- a/clang/lib/Frontend/StmtXML.cpp +++ b/clang/lib/Frontend/StmtXML.cpp @@ -163,8 +163,8 @@ namespace { void VisitObjCSelectorExpr(ObjCSelectorExpr *Node); void VisitObjCProtocolExpr(ObjCProtocolExpr *Node); void VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *Node); - void VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *Node); + void VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *Node); void VisitObjCIvarRefExpr(ObjCIvarRefExpr *Node); void VisitObjCSuperExpr(ObjCSuperExpr *Node); #endif @@ -439,8 +439,8 @@ void StmtXML::VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *Node) { Doc.addAttribute("property", Node->getProperty()->getNameAsString()); } -void StmtXML::VisitObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *Node) { +void StmtXML::VisitObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *Node) { DumpExpr(Node); ObjCMethodDecl *Getter = Node->getGetterMethod(); ObjCMethodDecl *Setter = Node->getSetterMethod(); diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index e7d9d505b2cf..9f2be1c70bb7 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -2173,7 +2173,7 @@ Sema::ActOnMemberReferenceExpr(Scope *S, ExprArg Base, SourceLocation OpLoc, // Get the expression type from Setter's incoming parameter. PType = (*(Setter->param_end() -1))->getType(); // FIXME: we must check that the setter has property type. - return Owned(new (Context) ObjCImplctSetterGetterRefExpr(Getter, PType, + return Owned(new (Context) ObjCImplicitSetterGetterRefExpr(Getter, PType, Setter, MemberLoc, BaseExpr)); } return ExprError(Diag(MemberLoc, diag::err_property_not_found) @@ -2364,7 +2364,7 @@ Sema::ActOnMemberReferenceExpr(Scope *S, ExprArg Base, SourceLocation OpLoc, // Get the expression type from Setter's incoming parameter. PType = (*(Setter->param_end() -1))->getType(); // FIXME: we must check that the setter has property type. - return Owned(new (Context) ObjCImplctSetterGetterRefExpr(Getter, PType, + return Owned(new (Context) ObjCImplicitSetterGetterRefExpr(Getter, PType, Setter, MemberLoc, BaseExpr)); } return ExprError(Diag(MemberLoc, diag::err_property_not_found) diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp index 3b28fae83cf7..d9ca49c8eb16 100644 --- a/clang/lib/Sema/SemaExprObjC.cpp +++ b/clang/lib/Sema/SemaExprObjC.cpp @@ -339,7 +339,7 @@ Action::OwningExprResult Sema::ActOnClassPropertyRefExpr( E = Setter->param_end(); PI != E; ++PI) PType = (*PI)->getType(); } - return Owned(new (Context) ObjCImplctSetterGetterRefExpr( + return Owned(new (Context) ObjCImplicitSetterGetterRefExpr( Getter, PType, Setter, propertyNameLoc, IFace, receiverNameLoc)); } diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp index 19a802e452db..ae59aec56583 100644 --- a/clang/lib/Sema/SemaStmt.cpp +++ b/clang/lib/Sema/SemaStmt.cpp @@ -70,7 +70,7 @@ void Sema::DiagnoseUnusedExprResult(const Stmt *S) { // cases now. unsigned DiagID = diag::warn_unused_expr; E = E->IgnoreParens(); - if (isa(E)) + if (isa(E)) DiagID = diag::warn_unused_property_expr; Diag(Loc, DiagID) << R1 << R2; diff --git a/clang/lib/Sema/TreeTransform.h b/clang/lib/Sema/TreeTransform.h index ae359bb550db..a0012546b2f3 100644 --- a/clang/lib/Sema/TreeTransform.h +++ b/clang/lib/Sema/TreeTransform.h @@ -4100,8 +4100,8 @@ TreeTransform::TransformObjCPropertyRefExpr(ObjCPropertyRefExpr *E) { template Sema::OwningExprResult -TreeTransform::TransformObjCImplctSetterGetterRefExpr( - ObjCImplctSetterGetterRefExpr *E) { +TreeTransform::TransformObjCImplicitSetterGetterRefExpr( + ObjCImplicitSetterGetterRefExpr *E) { // FIXME: Implement this! assert(false && "Cannot transform Objective-C expressions yet"); return SemaRef.Owned(E->Retain());