mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 18:56:43 +00:00
Code Issues Projects Releases Wiki Activity

[LLD] [COFF] Port -lto-sample-profile to COFF version of LLD (#85701)

Browse Source 
Following the commit of #83972 which added COFF support for SPGO, this
patch ports the support of the option -lto-sample-profile that was only
available in the ELF variant of LLD to the COFF variant to enable
running the SPGO passes in the LTO/thinLTO pipelines.
This commit is contained in:
chrulski-intel 2024-03-20 08:02:43 -07:00 committed by GitHub
parent 647d75d3a8
commit a9fe23cde3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lld/COFF/Config.h
View File

@ -263,6 +263,9 @@ struct Configuration {
// Used for /lto-pgo-warn-mismatch:
bool ltoPGOWarnMismatch = true;
// Used for /lto-sample-profile:
llvm::StringRef ltoSampleProfileName;
// Used for /call-graph-ordering-file:
llvm::MapVector<std::pair<const SectionChunk *, const SectionChunk *>,
uint64_t>

1
lld/COFF/Driver.cpp
View File

@ -2028,6 +2028,7 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
config->ltoObjPath = args.getLastArgValue(OPT_lto_obj_path);
config->ltoCSProfileGenerate = args.hasArg(OPT_lto_cs_profile_generate);
config->ltoCSProfileFile = args.getLastArgValue(OPT_lto_cs_profile_file);
config->ltoSampleProfileName = args.getLastArgValue(OPT_lto_sample_profile);
// Handle miscellaneous boolean flags.
config->ltoPGOWarnMismatch = args.hasFlag(OPT_lto_pgo_warn_mismatch,
OPT_lto_pgo_warn_mismatch_no, true);

1
lld/COFF/LTO.cpp
View File

@ -86,6 +86,7 @@ lto::Config BitcodeCompiler::createConfig() {
c.CSIRProfile = std::string(ctx.config.ltoCSProfileFile);
c.RunCSIRInstr = ctx.config.ltoCSProfileGenerate;
c.PGOWarnMismatch = ctx.config.ltoPGOWarnMismatch;
c.SampleProfile = ctx.config.ltoSampleProfileName;
c.TimeTraceEnabled = ctx.config.timeTraceEnabled;
c.TimeTraceGranularity = ctx.config.timeTraceGranularity;

1
lld/COFF/Options.td
View File

@ -79,6 +79,7 @@ def lldltocachepolicy : P<"lldltocachepolicy",
"Pruning policy for the ThinLTO cache">;
def lldsavetemps : F<"lldsavetemps">,
HelpText<"Save intermediate LTO compilation results">;
def lto_sample_profile: P<"lto-sample-profile", "Sample profile file path">;
def machine : P<"machine", "Specify target platform">;
def merge : P<"merge", "Combine sections">;
def mllvm : P<"mllvm", "Options to pass to LLVM">;

1
lld/test/COFF/Inputs/lto-sample-profile.prof Normal file
View File

@ -0,0 +1 @@
f:0:0

23
lld/test/COFF/lto-sample-profile.ll Normal file
View File

@ -0,0 +1,23 @@
; REQUIRES: x86
; RUN: opt -module-summary %s -o %t1.o
; RUN: opt -module-summary %p/Inputs/thinlto.ll -o %t2.o
; RUN: rm -f %t1.o.4.opt.bc
; RUN: lld-link /lto-sample-profile:%p/Inputs/lto-sample-profile.prof /lldsavetemps /entry:f /subsystem:console %t1.o %t2.o /out:%t3.exe
; RUN: opt -S %t1.o.4.opt.bc | FileCheck %s
target datalayout = "e-m:w-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-windows-msvc19.0.24215"
; CHECK: ![[#]] = !{i32 1, !"ProfileSummary", ![[#]]}
declare void @g(...)
define void @h() {
ret void
}
define void @f() {
entry:
call void (...) @g()
call void (...) @h()
ret void
}