mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-25 08:06:06 +00:00
Code Issues Projects Releases Wiki Activity

Not content to implement just "extern" explicit template

Browse Source 
instantiations, GCC also supports "inline" and "static" explicit
template instantiations. Parse and warn about such constructs, but
don't implement the semantics of either "inline" or "static". They
don't seem to be widely used.

llvm-svn: 120599
This commit is contained in:
Douglas Gregor 2010-12-01 20:32:20 +00:00
parent 67056b613d
commit aa49ecc458
3 changed files with 38 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/include/clang/Basic/DiagnosticParseKinds.td
View File

@ -348,6 +348,10 @@ def err_enum_template : Error<"enumeration cannot be a template">;
def err_missing_dependent_template_keyword : Error<
"use 'template' keyword to treat '%0' as a dependent template name">;
def warn_static_inline_explicit_inst_ignored : Warning<
"ignoring '%select{static|inline}0' keyword on explicit template "
"instantiation">;
// Constructor template diagnostics.
def err_out_of_line_constructor_template_id : Error<
"out-of-line constructor for %0 cannot have template arguments">;

34
clang/lib/Parse/Parser.cpp
View File

@ -525,12 +525,38 @@ Parser::DeclGroupPtrTy Parser::ParseExternalDeclaration(CXX0XAttributeList Attr,
return ParseDeclaration(Stmts, Declarator::FileContext, DeclEnd, Attr);
}
case tok::kw_inline:
if (getLang().CPlusPlus && NextToken().is(tok::kw_namespace)) {
// Inline namespaces. Allowed as an extension even in C++03.
case tok::kw_static:
// Parse (then ignore) 'static' prior to a template instantiation. This is
// a GCC extension that we intentionally do not support.
if (getLang().CPlusPlus && NextToken().is(tok::kw_template)) {
Diag(ConsumeToken(), diag::warn_static_inline_explicit_inst_ignored)
<< 0;
SourceLocation DeclEnd;
StmtVector Stmts(Actions);
return ParseDeclaration(Stmts, Declarator::FileContext, DeclEnd, Attr);
return ParseDeclaration(Stmts, Declarator::FileContext, DeclEnd, Attr);
}
goto dont_know;
case tok::kw_inline:
if (getLang().CPlusPlus) {
tok::TokenKind NextKind = NextToken().getKind();
// Inline namespaces. Allowed as an extension even in C++03.
if (NextKind == tok::kw_namespace) {
SourceLocation DeclEnd;
StmtVector Stmts(Actions);
return ParseDeclaration(Stmts, Declarator::FileContext, DeclEnd, Attr);
}
// Parse (then ignore) 'inline' prior to a template instantiation. This is
// a GCC extension that we intentionally do not support.
if (NextKind == tok::kw_template) {
Diag(ConsumeToken(), diag::warn_static_inline_explicit_inst_ignored)
<< 1;
SourceLocation DeclEnd;
StmtVector Stmts(Actions);
return ParseDeclaration(Stmts, Declarator::FileContext, DeclEnd, Attr);
}
}
goto dont_know;

4
clang/test/SemaTemplate/explicit-instantiation.cpp
View File

@ -84,6 +84,10 @@ namespace explicit_instantiation_after_implicit_instantiation {
template struct X0<1>;
}
template<typename> struct X3 { };
inline template struct X3<int>; // expected-warning{{ignoring 'inline' keyword on explicit template instantiation}}
static template struct X3<float>; // expected-warning{{ignoring 'static' keyword on explicit template instantiation}}
namespace PR7622 { // expected-note{{to match this}}
template<typename,typename=int>
struct basic_streambuf;