mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 19:16:43 +00:00
Code Issues Projects Releases Wiki Activity

[flang] Enforce F'2023 constraints C917 & C918 (#129962)

Browse Source 
These are constraints that preclude the need to obtain type information
from descriptors on other images, essentially. When designating a
polymorphic component, its base may not be coindexed; nor shall a
coindexed designator have a type with a polymorphic potential subobject
component.
This commit is contained in:
Peter Klausler 2025-03-10 16:48:37 -07:00 committed by GitHub
parent ae23dd5d99
commit af62a6f59a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 46 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
flang/lib/Semantics/expression.cpp
View File

@ -650,8 +650,25 @@ MaybeExpr ExpressionAnalyzer::Analyze(const parser::Designator &d) {
dataRef = ExtractDataRef(std::move(result),
/*intoSubstring=*/false, /*intoComplexPart=*/true);
}
if (dataRef && !CheckDataRef(*dataRef)) {
result.reset();
if (dataRef) {
if (!CheckDataRef(*dataRef)) {
result.reset();
} else if (ExtractCoarrayRef(*dataRef).has_value()) {
if (auto dyType{result->GetType()};
dyType && dyType->category() == TypeCategory::Derived) {
if (!std::holds_alternative<CoarrayRef>(dataRef->u) &&
dyType->IsPolymorphic()) { // F'2023 C918
Say("The base of a polymorphic object may not be coindexed"_err_en_US);
}
if (const auto *derived{GetDerivedTypeSpec(*dyType)}) {
if (auto bad{FindPolymorphicAllocatablePotentialComponent(
*derived)}) { // F'2023 C917
Say("A coindexed designator may not have a type with the polymorphic potential subobject component '%s'"_err_en_US,
bad.BuildResultDesignatorName());
}
}
}
}
}
}
return result;

28
flang/test/Semantics/coarrays02.f90
View File

@ -1,6 +1,6 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
! More coarray error tests.
module m
module m1
integer :: local[*] ! ok in module
end
program main
@ -49,6 +49,32 @@ function func2()
type(t) :: local
end
module m2
type t0
integer n
end type
type t1
class(t0), allocatable :: a
end type
type t2
type(t1) c
end type
contains
subroutine test(x)
type(t2), intent(in) :: x[*]
!ERROR: The base of a polymorphic object may not be coindexed
call sub1(x[1]%c%a)
!ERROR: A coindexed designator may not have a type with the polymorphic potential subobject component '%a'
call sub2(x[1]%c)
end
subroutine sub1(x)
type(t0), intent(in) :: x
end
subroutine sub2(x)
type(t1), intent(in) :: x
end
end
module m3
type t
real, allocatable :: a(:)