mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-17 21:26:53 +00:00
Code Issues Projects Releases Wiki Activity

[llvm][ELF][build attributes] Change StringRef to std::string for BuildAttributeSubSection::Name (#135625)

Browse Source 
BuildAttributeSubSection::Name must be a std::string instead of
StringRef because it may be assigned from non-persistent memory.
StringRef is non-owning and unsafe in this context. This change ensures
the subsection name owns its memory, preventing use-after-free or
dangling references.

Context: Work in progress in PR #131990.
This commit is contained in:
SivanShani-Arm 2025-04-14 14:59:24 +01:00 committed by GitHub
parent 74e8f29f31
commit bcbdbd25c0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/include/llvm/Support/ELFAttributes.h
View File

@ -36,7 +36,7 @@ struct BuildAttributeItem {
: Type(Ty), Tag(Tg), IntValue(IV), StringValue(std::move(SV)) {} : Type(Ty), Tag(Tg), IntValue(IV), StringValue(std::move(SV)) {}
}; };
struct BuildAttributeSubSection { struct BuildAttributeSubSection {
StringRef Name; std::string Name;
unsigned IsOptional; unsigned IsOptional;
unsigned ParameterType; unsigned ParameterType;
SmallVector<BuildAttributeItem, 64> Content; SmallVector<BuildAttributeItem, 64> Content;