mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-25 13:56:07 +00:00
Code Issues Projects Releases Wiki Activity

[mlir][Transforms][NFC] Dialect conversion: Fix typo and improve docs (#107539)

Browse Source
This commit is contained in:
Matthias Springer 2024-09-06 10:35:07 +02:00 committed by GitHub
parent 77b388cfc6
commit c2e53b2d50
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mlir/docs/DialectConversion.md
View File

@ -383,6 +383,11 @@ class TypeConverter {
};
```
Materializations through the type converter are optional. If the
`ConversionConfig::buildMaterializations` flag is set to "false", the dialect
conversion driver builds an `unrealized_conversion_cast` op instead of calling
the respective type converter callback whenever a materialization is required.
### Region Signature Conversion
From the perspective of type conversion, the types of block arguments are a bit

9
mlir/include/mlir/Transforms/DialectConversion.h
View File

@ -1127,13 +1127,12 @@ struct ConversionConfig {
/// If set to "true", the dialect conversion attempts to build source/target/
/// argument materializations through the type converter API in lieu of
/// builtin.unrealized_conversion_cast ops. The conversion process fails if
/// "builtin.unrealized_conversion_cast ops". The conversion process fails if
/// at least one materialization could not be built.
///
/// If set to "false", the dialect conversion does not does not build any
/// custom materializations and instead inserts
/// builtin.unrealized_conversion_cast ops to ensure that the resulting IR
/// is valid.
/// If set to "false", the dialect conversion does not build any custom
/// materializations and instead inserts "builtin.unrealized_conversion_cast"
/// ops to ensure that the resulting IR is valid.
bool buildMaterializations = true;
};