mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 15:36:58 +00:00
Code Issues Projects Releases Wiki Activity

[lld-macho] Remove redundant hasValidData. NFC

Browse Source 
lld::macho::runBalancedPartitioning ensures that all sections satisfy
`hasValidData`.
This commit is contained in:
Fangrui Song 2025-01-05 15:59:17 -08:00
parent f4230b4332
commit c2f7745b4e
3 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lld/Common/BPSectionOrdererBase.cpp
View File

@ -109,9 +109,6 @@ BPSectionBase::reorderSectionsByBalancedPartitioning(
// Process input sections
for (const auto &isec : inputSections) {
if (!isec->hasValidData())
continue;
unsigned sectionIdx = sections.size();
sectionToIdx.try_emplace(isec->getSection(), sectionIdx);
sections.emplace_back(isec.get());
@ -371,4 +368,4 @@ BPSectionBase::reorderSectionsByBalancedPartitioning(
for (const auto *isec : orderedSections)
sectionPriorities[isec] = --highestAvailablePriority;
return sectionPriorities;
}
}

4
lld/MachO/BPSectionOrderer.h
View File

@ -68,10 +68,6 @@ public:
bool isCodeSection() const override { return macho::isCodeSection(isec); }
bool hasValidData() const override {
return isec && !isec->data.empty() && isec->data.data();
}
SmallVector<std::unique_ptr<BPSymbol>> getSymbols() const override {
SmallVector<std::unique_ptr<BPSymbol>> symbols;
for (auto *sym : isec->symbols)

1
lld/include/lld/Common/BPSectionOrdererBase.h
View File

@ -37,7 +37,6 @@ class BPSectionBase {
public:
virtual ~BPSectionBase() = default;
virtual uint64_t getSize() const = 0;
virtual bool hasValidData() const = 0;
virtual bool isCodeSection() const = 0;
virtual llvm::SmallVector<std::unique_ptr<BPSymbol>> getSymbols() const = 0;
virtual const void *getSection() const = 0;