[llvm] Use range-based for loops (NFC)

llvm/lib/CodeGen/InlineSpiller.cpp

@@ -581,11 +581,9 @@ bool InlineSpiller::reMaterializeFor(LiveInterval &VirtReg, MachineInstr &MI) {
 
   if (!ParentVNI) {
     LLVM_DEBUG(dbgs() << "\tadding <undef> flags: ");
-    for (unsigned i = 0, e = MI.getNumOperands(); i != e; ++i) {
+    for (MachineOperand &MO : MI.operands())
-      MachineOperand &MO = MI.getOperand(i);
       if (MO.isReg() && MO.isUse() && MO.getReg() == VirtReg.reg())
         MO.setIsUndef();
-    }
     LLVM_DEBUG(dbgs() << UseIdx << '\t' << MI);
     return true;
   }

llvm/lib/CodeGen/MachinePipeliner.cpp

@@ -2546,8 +2546,7 @@ void SMSchedule::orderDependence(SwingSchedulerDAG *SSD, SUnit *SU,
   unsigned Pos = 0;
   for (std::deque<SUnit *>::iterator I = Insts.begin(), E = Insts.end(); I != E;
        ++I, ++Pos) {
-    for (unsigned i = 0, e = MI->getNumOperands(); i < e; ++i) {
+    for (MachineOperand &MO : MI->operands()) {
-      MachineOperand &MO = MI->getOperand(i);
       if (!MO.isReg() || !Register::isVirtualRegister(MO.getReg()))
         continue;
 

llvm/lib/CodeGen/ModuloSchedule.cpp

@@ -1005,8 +1005,7 @@ void ModuloScheduleExpander::updateInstruction(MachineInstr *NewMI,
                                                unsigned CurStageNum,
                                                unsigned InstrStageNum,
                                                ValueMapTy *VRMap) {
-  for (unsigned i = 0, e = NewMI->getNumOperands(); i != e; ++i) {
+  for (MachineOperand &MO : NewMI->operands()) {
-    MachineOperand &MO = NewMI->getOperand(i);
     if (!MO.isReg() || !Register::isVirtualRegister(MO.getReg()))
       continue;
     Register reg = MO.getReg();

llvm/lib/CodeGen/RegAllocFast.cpp

@@ -1258,8 +1258,7 @@ void RegAllocFast::allocateInstruction(MachineInstr &MI) {
     // Free registers occupied by defs.
     // Iterate operands in reverse order, so we see the implicit super register
     // defs first (we added them earlier in case of <def,read-undef>).
-    for (unsigned I = MI.getNumOperands(); I-- > 0;) {
+    for (MachineOperand &MO : llvm::reverse(MI.operands())) {
-      MachineOperand &MO = MI.getOperand(I);
       if (!MO.isReg() || !MO.isDef())
         continue;
 
@@ -1362,8 +1361,7 @@ void RegAllocFast::allocateInstruction(MachineInstr &MI) {
 
   // Free early clobbers.
   if (HasEarlyClobber) {
-    for (unsigned I = MI.getNumOperands(); I-- > 0; ) {
+    for (MachineOperand &MO : llvm::reverse(MI.operands())) {
-      MachineOperand &MO = MI.getOperand(I);
       if (!MO.isReg() || !MO.isDef() || !MO.isEarlyClobber())
         continue;
       // subreg defs don't free the full register. We left the subreg number
@@ -1440,8 +1438,7 @@ void RegAllocFast::handleBundle(MachineInstr &MI) {
   MachineBasicBlock::instr_iterator BundledMI = MI.getIterator();
   ++BundledMI;
   while (BundledMI->isBundledWithPred()) {
-    for (unsigned I = 0; I < BundledMI->getNumOperands(); ++I) {
+    for (MachineOperand &MO : BundledMI->operands()) {
-      MachineOperand &MO = BundledMI->getOperand(I);
       if (!MO.isReg())
         continue;
 

llvm/lib/CodeGen/StackSlotColoring.cpp

@@ -393,8 +393,7 @@ void StackSlotColoring::RewriteInstruction(MachineInstr &MI,
                                            SmallVectorImpl<int> &SlotMapping,
                                            MachineFunction &MF) {
   // Update the operands.
-  for (unsigned i = 0, ee = MI.getNumOperands(); i != ee; ++i) {
+  for (MachineOperand &MO : MI.operands()) {
-    MachineOperand &MO = MI.getOperand(i);
     if (!MO.isFI())
       continue;
     int OldFI = MO.getIndex();

llvm/lib/Target/AArch64/AArch64CondBrTuning.cpp

@@ -88,12 +88,9 @@ MachineInstr *AArch64CondBrTuning::convertToFlagSetting(MachineInstr &MI,
   // If this is already the flag setting version of the instruction (e.g., SUBS)
   // just make sure the implicit-def of NZCV isn't marked dead.
   if (IsFlagSetting) {
-    for (unsigned I = MI.getNumExplicitOperands(), E = MI.getNumOperands();
+    for (MachineOperand &MO : MI.implicit_operands())
-         I != E; ++I) {
-      MachineOperand &MO = MI.getOperand(I);
       if (MO.isReg() && MO.isDead() && MO.getReg() == AArch64::NZCV)
         MO.setIsDead(false);
-    }
     return &MI;
   }
   bool Is64Bit;

llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp

@@ -6452,8 +6452,7 @@ static void fixupPHIOpBanks(MachineInstr &MI, MachineRegisterInfo &MRI,
   MachineIRBuilder MIB(MI);
 
   // Go through each operand and ensure it has the same regbank.
-  for (unsigned OpIdx = 1; OpIdx < MI.getNumOperands(); ++OpIdx) {
+  for (MachineOperand &MO : llvm::drop_begin(MI.operands())) {
-    MachineOperand &MO = MI.getOperand(OpIdx);
     if (!MO.isReg())
       continue;
     Register OpReg = MO.getReg();

llvm/lib/Target/ARM/ARMConstantIslandPass.cpp

@@ -1219,9 +1219,9 @@ int ARMConstantIslands::findInRangeCPEntry(CPUser& U, unsigned UserOffset) {
       // Point the CPUser node to the replacement
       U.CPEMI = CPEs[i].CPEMI;
       // Change the CPI in the instruction operand to refer to the clone.
-      for (unsigned j = 0, e = UserMI->getNumOperands(); j != e; ++j)
+      for (MachineOperand &MO : UserMI->operands())
-        if (UserMI->getOperand(j).isCPI()) {
+        if (MO.isCPI()) {
-          UserMI->getOperand(j).setIndex(CPEs[i].CPI);
+          MO.setIndex(CPEs[i].CPI);
           break;
         }
       // Adjust the refcount of the clone...
@@ -1601,9 +1601,9 @@ bool ARMConstantIslands::handleConstantPoolUser(unsigned CPUserIndex,
   BBUtils->adjustBBOffsetsAfter(&*--NewIsland->getIterator());
 
   // Finally, change the CPI in the instruction operand to be ID.
-  for (unsigned i = 0, e = UserMI->getNumOperands(); i != e; ++i)
+  for (MachineOperand &MO : UserMI->operands())
-    if (UserMI->getOperand(i).isCPI()) {
+    if (MO.isCPI()) {
-      UserMI->getOperand(i).setIndex(ID);
+      MO.setIndex(ID);
       break;
     }
 

llvm/lib/Target/Hexagon/HexagonCopyToCombine.cpp

@@ -237,12 +237,9 @@ static bool isEvenReg(unsigned Reg) {
 }
 
 static void removeKillInfo(MachineInstr &MI, unsigned RegNotKilled) {
-  for (unsigned I = 0, E = MI.getNumOperands(); I != E; ++I) {
+  for (MachineOperand &Op : MI.operands())
-    MachineOperand &Op = MI.getOperand(I);
+    if (Op.isReg() && Op.getReg() == RegNotKilled && Op.isKill())
-    if (!Op.isReg() || Op.getReg() != RegNotKilled || !Op.isKill())
+      Op.setIsKill(false);
-      continue;
-    Op.setIsKill(false);
-  }
 }
 
 /// Returns true if it is unsafe to move a copy instruction from \p UseReg to

llvm/lib/Target/Mips/MipsConstantIslandPass.cpp

@@ -1066,9 +1066,9 @@ int MipsConstantIslands::findInRangeCPEntry(CPUser& U, unsigned UserOffset)
       // Point the CPUser node to the replacement
       U.CPEMI = CPEs[i].CPEMI;
       // Change the CPI in the instruction operand to refer to the clone.
-      for (unsigned j = 0, e = UserMI->getNumOperands(); j != e; ++j)
+      for (MachineOperand &MO : UserMI->operands())
-        if (UserMI->getOperand(j).isCPI()) {
+        if (MO.isCPI()) {
-          UserMI->getOperand(j).setIndex(CPEs[i].CPI);
+          MO.setIndex(CPEs[i].CPI);
           break;
         }
       // Adjust the refcount of the clone...
@@ -1122,9 +1122,9 @@ int MipsConstantIslands::findLongFormInRangeCPEntry
       // Point the CPUser node to the replacement
       U.CPEMI = CPEs[i].CPEMI;
       // Change the CPI in the instruction operand to refer to the clone.
-      for (unsigned j = 0, e = UserMI->getNumOperands(); j != e; ++j)
+      for (MachineOperand &MO : UserMI->operands())
-        if (UserMI->getOperand(j).isCPI()) {
+        if (MO.isCPI()) {
-          UserMI->getOperand(j).setIndex(CPEs[i].CPI);
+          MO.setIndex(CPEs[i].CPI);
           break;
         }
       // Adjust the refcount of the clone...
@@ -1392,9 +1392,9 @@ bool MipsConstantIslands::handleConstantPoolUser(unsigned CPUserIndex) {
   adjustBBOffsetsAfter(&*--NewIsland->getIterator());
 
   // Finally, change the CPI in the instruction operand to be ID.
-  for (unsigned i = 0, e = UserMI->getNumOperands(); i != e; ++i)
+  for (MachineOperand &MO : UserMI->operands())
-    if (UserMI->getOperand(i).isCPI()) {
+    if (MO.isCPI()) {
-      UserMI->getOperand(i).setIndex(ID);
+      MO.setIndex(ID);
       break;
     }
 

llvm/lib/Target/X86/X86ExpandPseudo.cpp

@@ -209,10 +209,8 @@ void X86ExpandPseudo::expandCALL_RVMARKER(MachineBasicBlock &MBB,
     llvm_unreachable("unexpected opcode");
 
   OriginalCall = BuildMI(MBB, MBBI, MI.getDebugLoc(), TII->get(Opc)).getInstr();
-  unsigned OpStart = 1;
   bool RAXImplicitDead = false;
-  for (; OpStart < MI.getNumOperands(); ++OpStart) {
+  for (MachineOperand &Op : llvm::drop_begin(MI.operands())) {
-    MachineOperand &Op = MI.getOperand(OpStart);
     // RAX may be 'implicit dead', if there are no other users of the return
     // value. We introduce a new use, so change it to 'implicit def'.
     if (Op.isReg() && Op.isImplicit() && Op.isDead() &&