mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-27 17:06:05 +00:00
Code Issues Projects Releases Wiki Activity

[Diagnostics] Diagnose -Wsizeof-array-div for array of pointers

Browse Source 
Differential Revision: https://reviews.llvm.org/D87990
This commit is contained in:
Dávid Bolvanský 2020-10-09 12:55:46 +02:00
parent 32cc8f7998
commit caf28b0a12
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/Sema/SemaExpr.cpp
View File

@ -10036,7 +10036,7 @@ static void DiagnoseDivisionSizeofPointerOrArray(Sema &S, Expr *LHS, Expr *RHS,
QualType RHSTy;
if (RUE->isArgumentType())
RHSTy = RUE->getArgumentType();
RHSTy = RUE->getArgumentType().getNonReferenceType();
else
RHSTy = RUE->getArgumentExpr()->IgnoreParens()->getType();

4
clang/test/Sema/div-sizeof-array.cpp
View File

@ -46,4 +46,8 @@ void test(void) {
int array[10];
int narray = sizeof(array) / sizeof(int &);
int narray2 = sizeof(array) / sizeof(decltype(array[0]));
int *arrptrs[10]; // expected-note {{array 'arrptrs' declared here}}
int len = sizeof(arrptrs) / sizeof(decltype(*arrptrs[0])); // expected-warning {{expression does not compute the number of elements in this array; element type is 'int *', not 'int'}}
// expected-note@-1 {{place parentheses around the 'sizeof(decltype(*arrptrs[0]))' expression to silence this warning}}
}

3
clang/test/Sema/div-sizeof-ptr.cpp
View File

@ -7,7 +7,7 @@ int f(Ty (&Array)[N]) {
typedef int int32;
void test(int *p, int **q) { // expected-note 5 {{pointer 'p' declared here}}
void test(int *p, int **q) { // expected-note 6 {{pointer 'p' declared here}}
const int *r; // expected-note {{pointer 'r' declared here}}
int a1 = sizeof(p) / sizeof(*p); // expected-warning {{'sizeof (p)' will return the size of the pointer, not the array itself}}
int a2 = sizeof p / sizeof *p; // expected-warning {{'sizeof p' will return the size of the pointer, not the array itself}}
@ -21,6 +21,7 @@ void test(int *p, int **q) { // expected-note 5 {{pointer 'p' declared
int a8 = sizeof(d) / sizeof(int); // expected-warning {{'sizeof (d)' will return the size of the pointer, not the array itself}}
int a9 = sizeof(*q) / sizeof(**q); // expected-warning {{'sizeof (*q)' will return the size of the pointer, not the array itself}}
int a10 = sizeof(p) / sizeof(decltype(*p)); // expected-warning {{'sizeof (p)' will return the size of the pointer, not the array itself}}
// Should not warn
int b1 = sizeof(int *) / sizeof(int);