From cb98fd977a25d3d778244da4012fd34acf7fab45 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Tue, 17 Sep 2024 09:38:17 -0400 Subject: [PATCH] Fix use of an uninitialized variable; NFC intended This was causing debug builds with Visual Studio to fail a number of HLSL tests. --- clang/lib/Sema/SemaHLSL.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp index 98c9d2532727..67792be994fa 100644 --- a/clang/lib/Sema/SemaHLSL.cpp +++ b/clang/lib/Sema/SemaHLSL.cpp @@ -573,7 +573,7 @@ bool clang::CreateHLSLAttributedResourceType( assert(AttrList.size() && "expected list of resource attributes"); QualType ContainedTy = QualType(); - TypeSourceInfo *ContainedTyInfo; + TypeSourceInfo *ContainedTyInfo = nullptr; SourceLocation LocBegin = AttrList[0]->getRange().getBegin(); SourceLocation LocEnd = AttrList[0]->getRange().getEnd(); @@ -641,7 +641,7 @@ bool clang::CreateHLSLAttributedResourceType( ResType = S.getASTContext().getHLSLAttributedResourceType( Wrapped, ContainedTy, ResAttrs); - if (LocInfo) { + if (LocInfo && ContainedTyInfo) { LocInfo->Range = SourceRange(LocBegin, LocEnd); LocInfo->ContainedTyInfo = ContainedTyInfo; }