mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-27 06:36:46 +00:00
Code Issues Projects Releases Wiki Activity

Set Support system_libs if WIN32, not just MSVC or MINGW (#95505)

Browse Source 
The previous check was false when compiling with `clang++`, which
prevented `ntdll` from being specified as a link library, causing an
undefined symbol error when trying to resolve `RtlGetLastNtStatus`.
Since we always want to link these libraries on Windows, the check can
be simplified to just `if( WIN32 )`.
This commit is contained in:
Jeremy Day 2024-06-14 12:17:39 -07:00 committed by GitHub
parent 005758eb6b
commit cc7a18c180
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Support/CMakeLists.txt
View File

@ -37,7 +37,7 @@ if(LLVM_ENABLE_ZSTD)
list(APPEND imported_libs ${zstd_target})
endif()
if( MSVC OR MINGW )
if( WIN32 )
# libuuid required for FOLDERID_Profile usage in lib/Support/Windows/Path.inc.
# advapi32 required for CryptAcquireContextW in lib/Support/Windows/Path.inc.
# ntdll required for RtlGetLastNtStatus in lib/Support/ErrorHandling.cpp.
@ -72,7 +72,7 @@ elseif( CMAKE_HOST_UNIX )
add_compile_definitions(_BSD_SOURCE)
set(system_libs ${system_libs} bsd network)
endif()
endif( MSVC OR MINGW )
endif( WIN32 )
# Delay load shell32.dll if possible to speed up process startup.
set (delayload_flags)