mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-16 14:46:36 +00:00
Code Issues Projects Releases Wiki Activity

[LLD] [COFF] Preserve directives and export names from LTO objects (#78802)

Browse Source 
The export names are saved as StringRefs pointing into the COFF
directives. In the case of LTO objects, this can be memory allocated
that is owned by the LTO InputFile, which gets destructed when doing the
compilation.

In the case of LTO objects from an older version of LLVM, which require
being upgraded when loaded, the directives string gets destructed, while
when using LTO objects of a matching version (the common case), the
directives string points into memory that doesn't get destructed on LTO
compilation.

Test this by linking a bundled binary LTO object file, from an older
version of LLVM.

This fixes issue #78591, and downstream issue
https://github.com/mstorsjo/llvm-mingw/issues/392.
This commit is contained in:
Martin Storsjö 2024-01-20 16:15:44 +02:00 committed by GitHub
parent fcb6737f82
commit d0986519d5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lld/COFF/InputFiles.cpp
View File

@ -1081,7 +1081,7 @@ void BitcodeFile::parse() {
if (objSym.isUsed())
ctx.config.gcroot.push_back(sym);
}
directives = obj->getCOFFLinkerOpts();
directives = saver.save(obj->getCOFFLinkerOpts());
}
void BitcodeFile::parseLazy() {

BIN
lld/test/COFF/Inputs/lto-directives.obj Normal file
View File

Binary file not shown.

15
lld/test/COFF/lto-directives.test Normal file
View File

@ -0,0 +1,15 @@
; REQUIRES: x86
;; Test linking an LTO object file that contains directives. The
;; LTO object file is built with an older toolchain, to force it
;; to be upgraded when loaded.
;; The input file is compiled from source that looks like this:
;; void __declspec(dllexport) entry(void) { }
;; with this command:
;; clang -target x86_64-windows-msvc -c main.c -flto
; RUN: lld-link /entry:entry /subsystem:console %p/Inputs/lto-directives.obj /dll /out:%t.dll
; RUN: llvm-readobj --coff-exports %t.dll | FileCheck %s
; CHECK: Name: entry