mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 18:56:43 +00:00
Code Issues Projects Releases Wiki Activity

[LLD] [COFF] Don't create pseudo relocations for discardable sections (#89043)

Browse Source 
This extends on the case from 9c970d5ecd6a85188cd2b0a941fcd4d60063ef81;
if a section is marked discardable, it won't be mapped into memory at
runtime, so there's no point in creating runtime pseudo relocations for
such sections.
This commit is contained in:
Martin Storsjö 2024-04-18 13:30:29 +03:00 committed by GitHub
parent 750de326ef
commit d17db6066d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lld/COFF/Writer.cpp
View File

@ -2060,6 +2060,10 @@ void Writer::createRuntimePseudoRelocs() {
auto *sc = dyn_cast<SectionChunk>(c);
if (!sc || !sc->live)
continue;
// Don't create pseudo relocations for sections that won't be
// mapped at runtime.
if (sc->header->Characteristics & IMAGE_SCN_MEM_DISCARDABLE)
continue;
sc->getRuntimePseudoRelocs(rels);
}

43
lld/test/COFF/autoimport-debug.s Normal file
View File

@ -0,0 +1,43 @@
# REQUIRES: x86
# RUN: split-file %s %t.dir
## We've got references to variable both in a .refptr and in .debug_info.
## The .debug_info section should be discardable, so no pseudo relocations
## need to be created in it. The .refptr section should be elimiated
## and redirected to __imp_variable instead, so we shouldn't need to
## create any runtime pseudo relocations. Thus, test that we can link
## successfully with -runtime-pseudo-reloc:no, while keeping the
## debug info.
# RUN: llvm-mc -triple=x86_64-windows-gnu %t.dir/lib.s -filetype=obj -o %t.dir/lib.obj
# RUN: lld-link -out:%t.dir/lib.dll -dll -entry:DllMainCRTStartup %t.dir/lib.obj -lldmingw -implib:%t.dir/lib.lib
# RUN: llvm-mc -triple=x86_64-windows-gnu %t.dir/main.s -filetype=obj -o %t.dir/main.obj
# RUN: lld-link -lldmingw -out:%t.dir/main.exe -entry:main %t.dir/main.obj %t.dir/lib.lib -opt:noref -debug:dwarf -runtime-pseudo-reloc:no
#--- main.s
.global main
.text
main:
movq .refptr.variable(%rip), %rax
ret
.section .rdata$.refptr.variable,"dr",discard,.refptr.variable
.global .refptr.variable
.refptr.variable:
.quad variable
.section .debug_info
.long 1
.quad variable
.long 2
#--- lib.s
.global variable
.global DllMainCRTStartup
.text
DllMainCRTStartup:
ret
.data
variable:
.long 42