mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-18 12:06:38 +00:00
Code Issues Projects Releases Wiki Activity

[LLD][COFF] Mark personality functions as live in both symbol tables on ARM64X (#129295)

Browse Source
This commit is contained in:
Jacek Caban 2025-03-02 13:37:51 +01:00 committed by GitHub
parent 8eba022886
commit d403f33886
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 56 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lld/COFF/Driver.cpp
View File

@ -2766,14 +2766,16 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
// For now, just manually try to retain the known possible personality
// functions. This doesn't bring in more object files, but only marks
// functions that already have been included to be retained.
for (const char *n : {"__gxx_personality_v0", "__gcc_personality_v0",
"rust_eh_personality"}) {
Defined *d = dyn_cast_or_null<Defined>(ctx.symtab.findUnderscore(n));
if (d && !d->isGCRoot) {
d->isGCRoot = true;
config->gcroot.push_back(d);
ctx.forEachSymtab([&](SymbolTable &symtab) {
for (const char *n : {"__gxx_personality_v0", "__gcc_personality_v0",
"rust_eh_personality"}) {
Defined *d = dyn_cast_or_null<Defined>(symtab.findUnderscore(n));
if (d && !d->isGCRoot) {
d->isGCRoot = true;
config->gcroot.push_back(d);
}
}
}
});
}
markLive(ctx);

47
lld/test/COFF/gc-dwarf-eh-arm64x.s Normal file
View File

@ -0,0 +1,47 @@
# REQUIRES: aarch64
# RUN: llvm-mc -triple=aarch64-windows-gnu %s -filetype=obj -o %t-arm64.obj
# RUN: llvm-mc -triple=arm64ec-windows-gnu %s -filetype=obj -o %t-arm64ec.obj
# RUN: lld-link -machine:arm64x -lldmingw -out:%t.exe -opt:ref -entry:main %t-arm64.obj %t-arm64ec.obj -verbose 2>&1 | FileCheck %s
# CHECK: Discarded unused
# Check that __gxx_personality_v0 is not discarded and is present in the output.
# RUN: llvm-objdump -d %t.exe | FileCheck --check-prefix=DISASM %s
# DISASM: 0000000140001000 <.text>:
# DISASM-NEXT: 140001000: 52800000 mov w0, #0x0 // =0
# DISASM-NEXT: 140001004: d65f03c0 ret
# DISASM-NEXT: 140001008: 52800020 mov w0, #0x1 // =1
# DISASM-NEXT: 14000100c: d65f03c0 ret
# DISASM-NEXT: ...
# DISASM-NEXT: 140002000: 52800000 mov w0, #0x0 // =0
# DISASM-NEXT: 140002004: d65f03c0 ret
# DISASM-NEXT: 140002008: 52800020 mov w0, #0x1 // =1
# DISASM-NEXT: 14000200c: d65f03c0 ret
.def main; .scl 2; .type 32; .endef
.section .text,"xr",one_only,main
.globl main
main:
.cfi_startproc
.cfi_personality 0, __gxx_personality_v0
mov w0, #0
ret
.cfi_endproc
.def __gxx_personality_v0; .scl 2; .type 32; .endef
.section .text,"xr",one_only,__gxx_personality_v0
.globl __gxx_personality_v0
__gxx_personality_v0:
mov w0, #1
ret
.def unused; .scl 2; .type 32; .endef
.section .text,"xr",one_only,unused
.globl unused
unused:
.cfi_startproc
.cfi_personality 0, __gxx_personality_v0
mov w0, #2
ret
.cfi_endproc