From d7b89b0dcae802fd6405216514a82850243a47b1 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 14 Feb 2025 19:14:56 -0800 Subject: [PATCH] [CI] Do Not Consider a Job Failed if Steps Were Skipped This patch makes it so that skipped steps do not cause a job to be considered failed. The windows premerge jobs currently skip the build/test step if there are no projects to build/test. These show up as failures in the dashboard even though everything executed perfectly fine. Reviewers: lnihlen, Keenuts Reviewed By: lnihlen Pull Request: https://github.com/llvm/llvm-project/pull/127279 --- .ci/metrics/metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/metrics/metrics.py b/.ci/metrics/metrics.py index 09e00b3647d2..d219c9e55169 100644 --- a/.ci/metrics/metrics.py +++ b/.ci/metrics/metrics.py @@ -177,7 +177,7 @@ def get_per_workflow_metrics( # longer in a testing state and we can directly assert the workflow # result. for step in workflow_job.steps: - if step.conclusion != "success": + if step.conclusion != "success" and step.conclusion != "skipped": job_result = 0 break