From e6cc0faa73823387c31e96be132187643f2d7aee Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Sun, 19 Mar 2023 10:15:14 +0100 Subject: [PATCH] [runtimes] Don't use -Wall on clang-cl builds `-Wall` on clang-cl is equivalent to `-Weverything` on clang. We already add the correct warning flag depending whether we are in an MSVC-like environment, so just remove it from the list of flags that get passed unconditionally. Spies: libcxx-commits Differential Revision: https://reviews.llvm.org/D146378 --- runtimes/cmake/Modules/WarningFlags.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/runtimes/cmake/Modules/WarningFlags.cmake b/runtimes/cmake/Modules/WarningFlags.cmake index 8f78e19f1f35..d06409841dc9 100644 --- a/runtimes/cmake/Modules/WarningFlags.cmake +++ b/runtimes/cmake/Modules/WarningFlags.cmake @@ -12,7 +12,6 @@ function(cxx_add_warning_flags target enable_werror enable_pedantic) endif() # TODO: Should -Wconversion be enabled? target_add_compile_flags_if_supported(${target} PRIVATE - -Wall -Wextra -Wnewline-eof -Wshadow