mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-28 04:46:07 +00:00
Code Issues Projects Releases Wiki Activity

Explicitly exclude keywords from the member validator.

Browse Source 
Also simply and remove dead code from MemberExprTypoRecovery.

llvm-svn: 221723
This commit is contained in:
Kaelyn Takata 2014-11-11 23:00:40 +00:00
parent db99de2d15
commit e9e4ecfe9e
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
clang/lib/Sema/SemaExprMember.cpp
View File

@ -539,7 +539,15 @@ namespace {
class RecordMemberExprValidatorCCC : public CorrectionCandidateCallback {
public:
explicit RecordMemberExprValidatorCCC(const RecordType *RTy)
: Record(RTy->getDecl()) {}
: Record(RTy->getDecl()) {
// Don't add bare keywords to the consumer since they will always fail
// validation by virtue of not being associated with any decls.
WantTypeSpecifiers = false;
WantExpressionKeywords = false;
WantCXXNamedCasts = false;
WantFunctionLikeCasts = false;
WantRemainingKeywords = false;
}
bool ValidateCandidate(const TypoCorrection &candidate) override {
NamedDecl *ND = candidate.getCorrectionDecl();
@ -1214,9 +1222,6 @@ public:
OpLoc(OpLoc), IsArrow(IsArrow) {}
ExprResult operator()(Sema &SemaRef, TypoExpr *TE, TypoCorrection TC) {
if (TC.isKeyword())
return ExprError();
LookupResult R(SemaRef, TC.getCorrection(),
TC.getCorrectionRange().getBegin(),
SemaRef.getTypoExprState(TE)
@ -1224,12 +1229,6 @@ public:
.getLookupKind());
R.suppressDiagnostics();
QualType BaseType;
if (auto *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
BaseType = DRE->getDecl()->getType();
else if (auto *CE = dyn_cast<CallExpr>(BaseExpr))
BaseType = CE->getCallReturnType();
for (NamedDecl *ND : TC)
R.addDecl(ND);
R.resolveKind();