mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-19 00:56:41 +00:00
Code Issues Projects Releases Wiki Activity

[Support] Re-raise external signals (#125854)

Browse Source 
Otherwise, the handler "swallows" the signal and the process continues
to execute. While this use case is peculiar, ignoring these signals
entirely seems more odd.
This commit is contained in:
Guy David 2025-02-08 15:16:26 +02:00 committed by GitHub
parent 66bea0df75
commit ef23ba7da3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
llvm/lib/Support/Unix/Signals.inc
View File

@ -80,7 +80,7 @@
using namespace llvm;
static void SignalHandler(int Sig); // defined below.
static void SignalHandler(int Sig, siginfo_t *Info, void *);
static void InfoSignalHandler(int Sig); // defined below.
using SignalHandlerFunctionType = void (*)();
@ -313,8 +313,8 @@ static void RegisterHandlers() { // Not signal-safe.
switch (Kind) {
case SignalKind::IsKill:
NewHandler.sa_handler = SignalHandler;
NewHandler.sa_flags = SA_NODEFER | SA_RESETHAND | SA_ONSTACK;
NewHandler.sa_sigaction = SignalHandler;
NewHandler.sa_flags = SA_NODEFER | SA_RESETHAND | SA_ONSTACK | SA_SIGINFO;
break;
case SignalKind::IsInfo:
NewHandler.sa_handler = InfoSignalHandler;
@ -370,7 +370,7 @@ void sys::CleanupOnSignal(uintptr_t Context) {
}
// The signal handler that runs.
static void SignalHandler(int Sig) {
static void SignalHandler(int Sig, siginfo_t *Info, void *) {
// Restore the signal behavior to default, so that the program actually
// crashes when we return and the signal reissues. This also ensures that if
// we crash in our signal handler that the program will terminate immediately
@ -412,6 +412,11 @@ static void SignalHandler(int Sig) {
if (Sig == SIGILL || Sig == SIGFPE || Sig == SIGTRAP)
raise(Sig);
#endif
// Signal sent from another process, do not assume that continuing the
// execution would re-raise it.
if (Info->si_pid != getpid())
raise(Sig);
}
static void InfoSignalHandler(int Sig) {