mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-26 03:06:06 +00:00
Code Issues Projects Releases Wiki Activity

[lldb] Assert on invalid default {S,U}Int64 (NFC) (#126590)

Browse Source 
Both the default value and the min/max value are within LLDB's control,
so an assert is more appropriate than a runtime check.
This commit is contained in:
Jonas Devlieghere 2025-02-10 15:10:21 -08:00 committed by GitHub
parent fb623a3524
commit f451d27b38
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lldb/include/lldb/Interpreter/OptionValueSInt64.h
View File

@ -68,11 +68,10 @@ public:
}
bool SetDefaultValue(int64_t value) {
if (value >= m_min_value && value <= m_max_value) {
m_default_value = value;
return true;
}
return false;
assert(value >= m_min_value && value <= m_max_value &&
"disallowed default value");
m_default_value = value;
return true;
}
void SetMinimumValue(int64_t v) { m_min_value = v; }

13
lldb/include/lldb/Interpreter/OptionValueUInt64.h
View File

@ -73,18 +73,17 @@ public:
}
bool SetDefaultValue(uint64_t value) {
if (value >= m_min_value && value <= m_max_value) {
m_default_value = value;
return true;
}
return false;
assert(value >= m_min_value && value <= m_max_value &&
"disallowed default value");
m_default_value = value;
return true;
}
void SetMinimumValue(int64_t v) { m_min_value = v; }
void SetMinimumValue(uint64_t v) { m_min_value = v; }
uint64_t GetMinimumValue() const { return m_min_value; }
void SetMaximumValue(int64_t v) { m_max_value = v; }
void SetMaximumValue(uint64_t v) { m_max_value = v; }
uint64_t GetMaximumValue() const { return m_max_value; }