From f451d27b387cdff14f0f45f1b3314090a5008e0c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 10 Feb 2025 15:10:21 -0800 Subject: [PATCH] [lldb] Assert on invalid default {S,U}Int64 (NFC) (#126590) Both the default value and the min/max value are within LLDB's control, so an assert is more appropriate than a runtime check. --- lldb/include/lldb/Interpreter/OptionValueSInt64.h | 9 ++++----- lldb/include/lldb/Interpreter/OptionValueUInt64.h | 13 ++++++------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/lldb/include/lldb/Interpreter/OptionValueSInt64.h b/lldb/include/lldb/Interpreter/OptionValueSInt64.h index 3cf41d38c0ef..f7e72684e410 100644 --- a/lldb/include/lldb/Interpreter/OptionValueSInt64.h +++ b/lldb/include/lldb/Interpreter/OptionValueSInt64.h @@ -68,11 +68,10 @@ public: } bool SetDefaultValue(int64_t value) { - if (value >= m_min_value && value <= m_max_value) { - m_default_value = value; - return true; - } - return false; + assert(value >= m_min_value && value <= m_max_value && + "disallowed default value"); + m_default_value = value; + return true; } void SetMinimumValue(int64_t v) { m_min_value = v; } diff --git a/lldb/include/lldb/Interpreter/OptionValueUInt64.h b/lldb/include/lldb/Interpreter/OptionValueUInt64.h index 07076075790c..5cccff177cb1 100644 --- a/lldb/include/lldb/Interpreter/OptionValueUInt64.h +++ b/lldb/include/lldb/Interpreter/OptionValueUInt64.h @@ -73,18 +73,17 @@ public: } bool SetDefaultValue(uint64_t value) { - if (value >= m_min_value && value <= m_max_value) { - m_default_value = value; - return true; - } - return false; + assert(value >= m_min_value && value <= m_max_value && + "disallowed default value"); + m_default_value = value; + return true; } - void SetMinimumValue(int64_t v) { m_min_value = v; } + void SetMinimumValue(uint64_t v) { m_min_value = v; } uint64_t GetMinimumValue() const { return m_min_value; } - void SetMaximumValue(int64_t v) { m_max_value = v; } + void SetMaximumValue(uint64_t v) { m_max_value = v; } uint64_t GetMaximumValue() const { return m_max_value; }