From f50d7f76c6be0147fec33c2c9fdcce478aa01cfc Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sun, 7 Dec 2008 07:22:45 +0000 Subject: [PATCH] fix a bug I introduced in simplifycfg handling single entry phi nodes. FoldSingleEntryPHINodes deletes the PHI, so there is no need to delete it afterward. llvm-svn: 60653 --- llvm/lib/Transforms/Utils/SimplifyCFG.cpp | 1 - .../SimplifyCFG/2008-12-06-SingleEntryPhi.ll | 13 +++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 llvm/test/Transforms/SimplifyCFG/2008-12-06-SingleEntryPhi.ll diff --git a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp index d6465f599cf4..e7bd75e04931 100644 --- a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp +++ b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp @@ -1102,7 +1102,6 @@ static bool FoldCondBranchOnPHI(BranchInst *BI) { // Degenerate case of a single entry PHI. if (PN->getNumIncomingValues() == 1) { FoldSingleEntryPHINodes(PN->getParent()); - PN->eraseFromParent(); return true; } diff --git a/llvm/test/Transforms/SimplifyCFG/2008-12-06-SingleEntryPhi.ll b/llvm/test/Transforms/SimplifyCFG/2008-12-06-SingleEntryPhi.ll new file mode 100644 index 000000000000..7b4aee489b55 --- /dev/null +++ b/llvm/test/Transforms/SimplifyCFG/2008-12-06-SingleEntryPhi.ll @@ -0,0 +1,13 @@ +; RUN: llvm-as < %s | opt -simplifycfg | llvm-dis +define i32 @test() { +entry: + br label %T +T: + %C = phi i1 [false, %entry] + br i1 %C, label %X, label %Y +X: + ret i32 2 +Y: + add i32 1, 2 + ret i32 1 +}