477 Commits

Author SHA1 Message Date
Schuyler Eldridge
8a8ab8f70c
[lit][ci] Publish lit wheels (#88072)
Add wheel publishing in addition to existing source distribution
publishing of lit.

Fixes #63369. This also uses the exact fix proposed by @EFord36 in
#63369.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
2024-04-09 11:55:17 -04:00
Mark de Wever
b798c2af8b
[libc++][CI] Updates to Clang 19. (#85301)
Since we have released Clang 16 is no longer actively supported. However
the FreeBSD runner is still using this, so some tests still guard
against Clang 16.
2024-04-04 20:48:23 +02:00
Tom Stellard
817c6915ae
[workflows] Use issue-write workflow for warning about private emails (#87399)
This allows us to use the less privileged pull_request event for the
validate_email job, since this workflow no longer writes a comment
directly.
2024-04-02 13:36:08 -07:00
Daniel Grumberg
4c7de02bc0 [ExtractAPI] Add @daniel-grumberg into CODEOWNERS 2024-04-02 16:35:52 +01:00
Aiden Grossman
f6c87be1dd [Github] Fix typo in PR code formatting job
The recent change to split the PR code formatting job accidentally
misspelled the repository field when specifying the repository to fetch
the code formatting utils from. This patch fixes the spelling so that
the job does not throw a warning and clones the tools from the specified
repository.
2024-04-02 00:33:50 -07:00
Tom Stellard
649f9603a2
[workflows] issue-write: Avoid race condition when PR branch is deleted (#87118)
Fixes #87102 .
2024-04-01 15:17:24 -07:00
Tom Stellard
6b136ce738
[workflows] issue-write: Exit early if there are no comments (#87114)
This will eliminate some unnecessary REST API calls.
2024-04-01 14:35:39 -07:00
Tom Stellard
2fa46ca922
[workflows] Update the version of the scorecard-action (#86753)
I'm hoping this will fix the errors we've been seeing the last few days:

2024-03-19T20:44:07.4841482Z 2024/03/19 20:44:07 error signing scorecard
json results: error signing payload: getting key from Fulcio: verifying
SCT: updating local metadata and targets: error updating to TUF remote
mirror: invalid key
2024-03-27 06:25:10 -07:00
Tom Stellard
de917dc20e
[workflow] Don't add a comment when the first run of the formatter passes (#86335)
This was inadvertently changed in
2120f574103c487787390263b3692c4b167f6bdf.
2024-03-25 15:04:11 -07:00
Tom Stellard
2120f57410
Reapply [workflows] Split pr-code-format into two parts to make it more secure (#78215) (#80495)
Actions triggered by pull_request_target events have access to all
repository secrets, so it is unsafe to use them when executing untrusted
code. The pr-code-format workflow does not execute any untrusted code,
but it passes untrused input into clang-format. An attacker could use
this to exploit a flaw in clang-format and potentially gain access to
the repository secrets.
    
By splitting the workflow, we can use the pull_request target which is
more secure and isolate the issue write permissions in a separate job.
The pull_request target also makes it easier to test changes to the
code-format-helepr.py script, because the version of the script from the
pull request will be used rather than the version of the script from
main.
    
Fixes #77142
2024-03-22 11:45:51 -07:00
Oleksandr "Alex" Zinenko
db33444ffa
CODEOWNERS: extend scope of MLIR transform dialect
There are a bunch of related directories in another dialects.
2024-03-22 12:03:28 +01:00
Cyndy Ishida
dc74bf7a54 Add myself as codeowner for InstallAPI & TextAPI 2024-03-21 15:43:27 -07:00
Diego Caballero
8d1affb871
Update @dcaballe in CODEOWNERS (#86177)
It fixes a few rules that don't seem to be working and adding myself to a few paths where I've been contributing and can offer my review. Also minor sorting changes.
2024-03-21 15:28:36 -07:00
Guray Ozen
cc9186060a
[mlir][nvgpu][nvvm] Add myself as a primary reviewer for nvgpu and nvvm dialects (#85414) 2024-03-20 19:21:19 +01:00
Tom Stellard
d93363a0e8
workflows: Fix baseline version for llvm abi checks (#85166)
The baseline version calculations was assuming the minor release would
always be 0.
2024-03-19 06:55:10 -07:00
Owen Pan
6f39c1e284 [GitHub][workflows] Use latest clang-format version 18.1.1 (#85502) 2024-03-16 04:23:15 -07:00
Aiden Grossman
f1ca0b6ce8 Revert "[GitHub][workflows] Use latest clang-format version 18.1.1 (#85502)"
This reverts commit dec63221d56e8092557f29f1f2c127828d7521bb.

This probably needs more discussion before we can land it. The consensus
(from what I can gather) in https://discourse.llvm.org/t/rfc-clang-format-all-the-things/76614
is that we should be careful with version upgrades for consistency.
2024-03-16 02:45:27 -07:00
Owen Pan
dec63221d5
[GitHub][workflows] Use latest clang-format version 18.1.1 (#85502) 2024-03-16 02:17:49 -07:00
Justin Bogner
1b0072734f
[new-prs-labeler] Add "DXContainer" patterns to the backend:DirectX label (#85446)
This should make sure PRs like #84409 get labelled.
2024-03-15 11:45:27 -07:00
Jordan Rupprecht
accf0af6ee
[bazel] Add workflows to label and assign bazel PRs (#85352)
Bazel PRs aren't being tagged or auto assigned, so they're easily
missed, especially for those created by contributors w/o triage or
commit access.

I'm putting myself as the default auto reviewer, but only for the
purposes of making sure PRs don't get lost.
2024-03-15 09:39:25 -05:00
Timm Bäder
0b0798b702 [NFC] Subscribe myself to changes to {lib,test}/AST/Interp/ 2024-03-14 16:55:38 +01:00
Tom Stellard
175b533720
workflows: Add workaround for lld failures on MacOS (#85021)
See #81967
2024-03-13 10:44:12 -07:00
Tom Stellard
8d220d109d
workflows: Fix incorrect input name in release-binaries.yml (#84604)
In aa02002491333c42060373bc84f1ff5d2c76b4ce the input name was changed
from tag to release-version, but the code was never updated.
2024-03-11 16:03:32 -07:00
Tom Stellard
0be1c3b92b
[workflows] Mention the correct user who makes a /cherry-pick comment (#82680)
We were mentioning the creator of the issue with the comment rather than
the creator of the comment.

Fixes #82580
2024-03-09 14:20:15 -08:00
Tom Stellard
51207756b0
workflows: Fixes for building the release binaries (#83694)
Since aa02002491333c42060373bc84f1ff5d2c76b4ce we weren't installing the
correct dependencies, and since 2836d8edbfbcd461b25101ed58f93c862d65903a
we must pass a custom token to github-upload-release.py for verifying
permissions.
2024-03-08 11:13:34 -08:00
Aiden Grossman
9f5be5f009
[Github] Add repository checks to release-binaries workflow (#84437)
This patch adds repository checks to the release-binaries workflow jobs.
People were observing that the job was running on a schedule in their
forks. This only happens on old forks, but those probably exist in great
number given how prolific LLVM is. This is also good practice anyways,
on top of solving the direct problem of these jobs running with the cron
schedule on people's forks.
2024-03-08 00:13:11 -08:00
Vlad Serebrennikov
e85470232b Subscribe @Endilll to changes in Clang's Sema.h 2024-03-06 13:49:43 +03:00
Natalie Chouinard
da63746bdf
[infra] Add git to Linux container (#82687)
Fixes #82646
2024-03-05 11:09:10 -05:00
Aiden Grossman
09b34b998d
[Github] Make CI container build more reliable (#83707) 2024-03-03 11:47:44 -08:00
Mircea Trofin
91895f59f4
[pr-subscribers] added third-party:benchmark to new-prs-labeler (#83486) 2024-02-29 13:41:00 -08:00
Kai Nacke
8e28037374
[SystemZ] Add SystemZ path for the PR labeler (#82515)
Similar to #82200:
Add paths for SystemZ related changes to the PR labeler.

There is no pr-subscribers-backend:SystemZ team in the llvm org yet.
Much appreciated if some admin can help to create the team.
2024-02-22 09:52:44 -05:00
Tom Stellard
2836d8edbf
[workflows] Fix permissions check for creating new releases (#81163)
The default GitHub token does not have read permissions on the org, so
we need to use a custom token in order to read the members of the
llvm-release-managers team.
2024-02-20 17:52:38 -08:00
Chen Zheng
1cbe26d302
[PowerPC] add PowerPC path for PR labeler (#82200)
Add paths for PowerPC to the PR labeler.
2024-02-20 16:20:58 +08:00
Aiden Grossman
3e004d1e8b
[Github] Enable warnings as errors on flang sphinx build (#72723)
Now that the number of warnings in the flang sphinx build has come down
significantly, we can turn on warnings as errors in the sphinx build,
which is the default configuration in CMake.
2024-02-15 11:30:46 -08:00
Aiden Grossman
f086d80d9a [Github] Run documentation test build on change to the workflow
This makes it so that the documentation test build workflow will run
when the workflow itself is changed. This makes it much easier to test
inside of PRs that modify the workflow.
2024-02-15 11:09:52 -08:00
Tom Stellard
fe20a759fc
Use container on Linux to run llvm-project-tests workflow (#81349) 2024-02-14 16:05:52 -08:00
Nikita Popov
124cd11d7f Revert "[GitHub][workflows] Ask reviewers to merge PRs when author cannot (#81142)"
This reverts commit 38c706e30f5f339bfb0bfb26fd7b5c2d5086064a.

This workflow always fails in cases where it needs to create a
comment, due to a permissions issue, see the discussion at:
https://discourse.llvm.org/t/rfc-fyi-pull-request-greetings-for-new-contributors/75458/20
2024-02-14 11:33:36 +01:00
David Spickett
38c706e30f
[GitHub][workflows] Ask reviewers to merge PRs when author cannot (#81142)
This uses
https://pygithub.readthedocs.io/en/stable/github_objects/Repository.html?highlight=get_collaborator_permission#github.Repository.Repository.get_collaborator_permission.

Which does
https://docs.github.com/en/rest/collaborators/collaborators?apiVersion=2022-11-28#get-repository-permissions-for-a-user
and returns the top level "permission" key.

This is less detailed than the user/permissions key but should be fine
for this
use case.

When a review is submitted we check:
* If it's an approval.
* Whether we have already left a merge on behalf comment (by looking for
a hidden HTML comment).
* Whether the author has permissions to merge their own PR. 
* Whether the reviewer has permissions to merge.

If needed we leave a comment tagging the reviewer. If the reviewer also
doesn't have merge permission, then it asks them to find someone else
who does.
2024-02-13 14:52:02 +00:00
Tom Stellard
0267f9800e
[workflows] Add a new workflow for testing release branch CI (#81073)
Since we commit all changes to the release branch CI to main first, we
need someway to test that these changes to main don't break the CI.
2024-02-09 15:01:04 -08:00
Tom Stellard
bd65547805
[workflows] Create a more descriptive title and body when creating a PR for backports (#80396)
When a backport request is made, the resulting pull request will have a
title like this:

<release branch>: <First line of HEAD commit for the branch>

And a body that says:

Backport <commit0> <commit1> ..

Requested By: <user>
2024-02-09 13:04:49 -08:00
Davide Italiano
7b5a9bb8f0 [github/CODEOWNERS] Add Alexander as BOLT reviewer. 2024-02-08 14:23:54 -08:00
Tom Stellard
ab92f6274b
[workflows] Fix libclc CI tests (#80942)
This was broken by 1a6426067fb33a8a789978f6e229108787a041be.
2024-02-07 08:44:52 -08:00
Davide Italiano
33cfc1341f [github][CODEOWNERS] Add BOLT. 2024-02-06 10:33:50 -08:00
Aiden Grossman
8f80df0f52
[Github] Use building LLVM as perf-training for CI container (#80713)
This patch adjusts the build process for building the toolchain for the
CI container to perform more rigorous perf-training for PGO,
particularly building the entirety of LLVM as that is what showed the
best results while benchmarking. This patch also splits the job into two
stages to avoid timeouts due to the large increase in buildtime. There
are a couple other hacks added in here to make things work that we can
do away with eventually once we're able to run jobs like this on more
powerful self-hosted runners.
2024-02-05 18:16:19 -08:00
Tom Stellard
792d928e15
[workflows] Fix lldb-tests and libclc-tests (#80751)
This was broken by d25022bb689b9bf48a24c0ae6c29c1d3c2f32823, which
caused the workflow to pass an empty string to ninja as the target. The
'all' target is probably not the right target for these tests, but this
is what the behavior was before
d25022bb689b9bf48a24c0ae6c29c1d3c2f32823.
2024-02-05 16:44:11 -08:00
Anton Korobeynikov
ee06678a75 Add some clarification to email check message 2024-02-05 09:52:29 -08:00
David Spickett
bdc5a87f15
[GitHub][Workflows] Prevent multiple private email comments (temporarily) (#80648)
Seems the easiest way to quiet this workflow while we figure out the final form of it.
2024-02-05 09:48:04 -08:00
Tom Stellard
1a6426067f
[workflows] Use /mnt as the build directory on Linux (#80583)
There is more space available on /mnt (~56G) than on / (~30G), and we
are starting to see some of the CI jobs run out of disk space on Linux.
2024-02-05 09:46:19 -08:00
Natalie Chouinard
de46dc97b1
[SPIR-V] Include SPIRV-Tools tests in CI (#80479) 2024-02-05 09:51:13 -05:00
Aiden Grossman
4b34558f43 [Github] Fix triggers formatting in code format action
A recent comment modified the job to only run on the main branch, but
the formatting was slightly off, causing the job to not run. This patch
fixes the formatting so the job will run as expected.
2024-02-04 21:33:30 -08:00