mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-05-15 10:06:07 +00:00
Code Issues Projects Releases Wiki Activity
432,041 Commits 1,258 Branches 288 Tags
Commit Graph

15 Commits

Author SHA1 Message Date
Konstantin Varlamov
36c746ca2d [libc++][ranges] Implement ranges::rotate. 
Also fix `ranges::stable_sort` and `ranges::inplace_merge` to support
proxy iterators now that their internal implementations can correctly
dispatch `rotate`.

Differential Revision: https://reviews.llvm.org/D130758
 2022-08-03 16:04:24 -07:00
Konstantin Varlamov
6bdb642234 [libc++][ranges] Implement ranges::sample. 
Differential Revision: https://reviews.llvm.org/D130865
 2022-08-02 22:34:23 -07:00
Hui Xie
72f57e3a30 [libc++][ranges] implement std::ranges::unique{_copy} 
implement `std::ranges::unique` and `std::ranges::unique_copy`

Differential Revision: https://reviews.llvm.org/D130404
 2022-07-29 08:28:17 +01:00
Konstantin Varlamov
b3afea1ce0 [libc++] Make _IterOps::__iter_move more similar to std::ranges::iter_move. 
Avoid relying on `iterator_traits` and instead deduce the return type of
dereferencing the iterator. Additionally, add a static check to reject
iterators with incorrect `iterator_traits` at compile time.

Differential Revision: https://reviews.llvm.org/D130538
 2022-07-28 02:06:57 -07:00
Hui Xie
0f6364b8a1 [libc++][ranges] implement std::ranges::equal_range 
implement `std::ranges::equal_range` which delegates to
`std::equal_range`

Differential Revision: https://reviews.llvm.org/D129796
 2022-07-22 10:24:08 +01:00
Hui Xie
7abbd6224b [libc++] Fix proxy iterator issues that trigger an assertion in Chromium. 
Crash report:
https://bugs.chromium.org/p/chromium/issues/detail?id=1346012

The triggered assertion is related sorting with `v8::internal::AtomicSlot`.
`AtomicSlot` is a proxy iterator with a proxy type `AtomicSlot::Reference`
(see 9bcb5eb590/src/objects/slots-atomic-inl.h).

https://reviews.llvm.org/D130197 correctly spotted the issue in
`__iter_move` but doesn't actually fix the issue. The reason is that
`AtomicSlot::operator*` returns a prvalue `Reference`. After the fix in
D130197, the return type of `__iter_move` is `Reference&&`. But the
rvalue reference is bound to the temporary value returned by
`operator*`, which will be dangling after `__iter_move` returns.

The idea of the fix in this change is borrowed from C++17's move_iterator
https://timsong-cpp.github.io/cppwp/n4659/move.iterators#move.iterator-1
When the underlying reference is a prvalue, we just return it by value.

Differential Revision: https://reviews.llvm.org/D130212
 2022-07-20 18:05:49 -07:00
Konstantin Varlamov
bc4d2e7051 [libc++] Fix _IterOps::__iter_move to support proxy iterators. 
The return type was specified incorrectly for proxy iterators that
define `reference` to be a class that implicitly converts to
`value_type`. `__iter_move` would end up returning an object of type
`reference` which would then implicitly convert to `value_type`; thus,
the function will return a `value_type&&` rvalue reference to the local
temporary.

Differential Revision: https://reviews.llvm.org/D130197
 2022-07-20 13:19:00 -07:00
Konstantin Varlamov
8ed702b83f [libc++][ranges] Implement ranges::{,stable_}partition. 
Differential Revision: https://reviews.llvm.org/D129624
 2022-07-18 21:06:17 -07:00
Konstantin Varlamov
a7c3379cf9 [libc++][ranges] Make range algorithms support proxy iterators 
Also test all the range algorithms to verify the support.

Differential Revision: https://reviews.llvm.org/D129823
 2022-07-17 18:12:06 -07:00
Nikolas Klauser
101d1e9b3c [libc++] Implement ranges::find_end, ranges::search{, _n} 
Reviewed By: var-const, #libc, huixie90

Spies: thakis, h-vetinari, huixie90, libcxx-commits, mgorny

Differential Revision: https://reviews.llvm.org/D124079
 2022-07-13 20:30:55 +02:00
Nikolas Klauser
1f04759316 Revert "[libc++] Implement ranges::find_end, ranges::search{, _n}" 
This reverts commit 76a76518507ccc59ccdad5b83f44dc8c3d9593c7.
 2022-07-13 13:41:25 +02:00
Nikolas Klauser
76a7651850 [libc++] Implement ranges::find_end, ranges::search{, _n} 
Reviewed By: var-const, #libc, huixie90

Spies: h-vetinari, huixie90, libcxx-commits, mgorny

Differential Revision: https://reviews.llvm.org/D124079
 2022-07-13 13:11:26 +02:00
Konstantin Varlamov
295b951ebc [lib++][ranges][NFC] Refactor iterator_operations.h to use tags. 
Change the mechanism in `iterator_operations.h` to pass around a generic
policy tag indicating whether an internal function is being invoked from
a "classic" STL algorithm or a ranges algorithm. `IterOps` is now
a template class specialized on the policy tag.

The advantage is that this mechanism is more generic and allows defining
arbitrary conditions in a clean manner.

Also add a few more iterator functions to `IterOps`.

Differential Revision: https://reviews.llvm.org/D129390
 2022-07-12 17:53:58 -07:00
Hui Xie
96b674f23c [libc++][ranges] implement std::ranges::set_intersection 
implement `std::ranges::set_intersection` by reusing the classic `std::set_intersenction`
added unit tests

Differential Revision: https://reviews.llvm.org/D129233
 2022-07-11 06:55:09 +01:00
Nikolas Klauser
988682a389 [libc++] Fix std::lower_bound with C++20-hostile iterators 
Reviewed By: EricWF, #libc

Spies: sstefan1, libcxx-commits, mgorny

Differential Revision: https://reviews.llvm.org/D127577
 2022-06-13 12:19:28 +02:00