mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-05-01 05:46:07 +00:00
Code Issues Projects Releases Wiki Activity
179,385 Commits 1,258 Branches 288 Tags
Commit Graph

111 Commits

Author SHA1 Message Date
Craig Topper
2554294321 [C++11] Use 'nullptr'. Analysis edition. 
llvm-svn: 209191
 2014-05-20 04:30:07 +00:00
Aaron Ballman
9ee54d119c Converting some for loops to use range-based for loops. No functional changes intended. 
llvm-svn: 208810
 2014-05-14 20:42:13 +00:00
Aaron Ballman
59a72b93a2 Amending r208783 based on a suggestion by David Blaikie. 
llvm-svn: 208800
 2014-05-14 18:32:59 +00:00
Aaron Ballman
42f9a8a7f9 Replacing some manual iterations with standard algorithms. No functional changes intended. 
llvm-svn: 208783
 2014-05-14 15:01:43 +00:00
Aaron Ballman
2f3fc6badd Formatting and style changes; no functional changes intended. 
llvm-svn: 208774
 2014-05-14 13:03:55 +00:00
Aaron Ballman
0c6a14ca82 Amending r208439 to remove buildLExpr; this code isn't strictly required yet, and fixes a dead code warning. 
llvm-svn: 208440
 2014-05-09 18:44:48 +00:00
Aaron Ballman
7c192b452f Add the ability to use logical expressions for capability attributes. This is to allow requirements to be expressed not just in terms of lists, but in terms of logical expressions. Eg) 
void foo(void) __attribute__((requires_capability((FlightControl || Worker) && !Logger)));

This is WIP code.

llvm-svn: 208439
 2014-05-09 18:26:23 +00:00
Nico Weber
b0f9e4ace7 Remove unused typedef found by gcc's -Wunused-local-typedefs. 
llvm-svn: 207870
 2014-05-02 21:22:21 +00:00
Aaron Ballman
a82eaa70f1 Updated the attribute tablegen emitter for variadic arguments to emit a range accessor in addition to the iterators. Updated code using iterators to use range-based for loops. 
llvm-svn: 207837
 2014-05-02 13:35:42 +00:00
Aaron Ballman
0491afaf5f Updating to use more range-based for loops, nullptr and auto. No functional changes. 
llvm-svn: 206590
 2014-04-18 13:13:15 +00:00
Aaron Ballman
e80bfcd048 Making some public members into private members. This also introduces a bit more const-correctness, and now uses some range-based for loops. No functional changes intended. 
llvm-svn: 206503
 2014-04-17 21:44:08 +00:00
DeLesley Hutchins
7e615c2f65 Thread Safety Analysis: reorganized SExpr header files. No change in 
functionality.

llvm-svn: 205936
 2014-04-09 22:39:43 +00:00
DeLesley Hutchins
b2213910de Thread Safety Analysis: update to internal SExpr handling. 
This patch is the first part of a significant refactoring that seeks to restore
sanity to way thread safety analysis deals with capability expressions.  The
current patch merely provides an outline of the structure of the new system.
It's not yet connected to the actual analysis, so there's no change in
functionality.

llvm-svn: 205728
 2014-04-07 18:09:54 +00:00
Aaron Ballman
e044904301 Updating the capability attribute diagnostics to be more capability-neutral. Instead of using terminology such as "lock", "unlock" and "locked", the new terminology is "acquire", "release" and "held". Additionally, the capability attribute's name argument is now reported as part of the diagnostic, instead of hard coding as "mutex." 
llvm-svn: 205359
 2014-04-01 21:43:23 +00:00
Aaron Ballman
df115d9bf3 The release_capability, release_shared_capability and release_generic_capability functions are now functionally distinct for capability analysis. The unlock_function attribute maps directly to release_generic_capability. 
llvm-svn: 204469
 2014-03-21 14:48:48 +00:00
Aaron Ballman
18d85aed39 Replacing the exclusive_lock_function, shared_lock_function and unlock_function attributes with the acquire_capability and release_capability attributes. The old spellings will continue to work, but the underlying semantic attributes have been replaced. 
Downgraded the capability diagnostics from error to warning to match the desired behavior, and updated the existing test cases.

llvm-svn: 204350
 2014-03-20 16:02:49 +00:00
DeLesley Hutchins
d1c9b37db9 Thread safety analysis: move smart pointer checks from -Wthread-safety-beta 
to -Wthread-safety.

llvm-svn: 203510
 2014-03-10 23:03:49 +00:00
Aaron Ballman
be22bcb180 [C++11] Replacing DeclBase iterators specific_attr_begin() and specific_attr_end() with iterator_range specific_attrs(). Updating all of the usages of the iterators with range-based for loops. 
llvm-svn: 203474
 2014-03-10 17:08:28 +00:00
Aaron Ballman
69bb592ad1 Based on usage, the NamedDecl is always set when constructing a CallingContext, but none of the other optional parameters are. Removing the optional parameters, and making the NamedDecl required. 
No functional changes intended.

llvm-svn: 203149
 2014-03-06 19:37:24 +00:00
Aaron Ballman
19842c437a Refactored to use a simple helper function that wraps the logic of creating an SExprNode and returning the position in which it was inserted. 
No functional change intended.

llvm-svn: 203148
 2014-03-06 19:25:11 +00:00
Aaron Ballman
cea2609b59 Very minor simplification and typo correction; no functional changes intended. 
llvm-svn: 203144
 2014-03-06 19:10:16 +00:00
Aaron Ballman
efe348ec44 DeLesley Hutchins (who wrote the original thread-safety attribute functionality) and I have agreed to start migrating from lock-specific terminology to "capability"-specific terminology. This opens the door for future threading-related analysis passes so that a common nomenclature can be used. 
The following attributes have been (silently) deprecated, with their replacements listed:

lockable => capability
exclusive_locks_required => requires_capability
shared_locks_required => requires_shared_capability
locks_excluded => requires_capability

There are no functional changes intended.

llvm-svn: 201585
 2014-02-18 17:36:50 +00:00
Aaron Ballman
ee58e6d6d2 Switching getAttrs calls over to using a specific_attr_iterator. No functional changes intended. 
llvm-svn: 197681
 2013-12-19 15:35:31 +00:00
Aaron Ballman
9ead1243a5 Replacing calls to getAttr with calls to hasAttr for clarity. No functional change intended -- this only replaces Boolean uses of getAttr. 
llvm-svn: 197648
 2013-12-19 02:39:40 +00:00
Alp Toker
f6a24ce40f Fix a tranche of comment, test and doc typos 
llvm-svn: 196510
 2013-12-05 16:25:25 +00:00
Alp Toker
d473363876 Correct hyphenations in comments and assert messages 
This patch tries to avoid unrelated changes other than fixing a few
hyphen-related ambiguities in nearby lines.

llvm-svn: 196466
 2013-12-05 04:47:09 +00:00
DeLesley Hutchins
39b804f8a4 Thread safety analysis: fix ICE due to missing null check on dyn_cast. 
llvm-svn: 195777
 2013-11-26 19:45:21 +00:00
DeLesley Hutchins
e73d6b605c Thread-safety analysis: check guarded_by and pt_guarded_by on array access. 
Currently supported only with -Wthread-safety-beta.

llvm-svn: 194275
 2013-11-08 19:42:01 +00:00
DeLesley Hutchins
05b7b37021 Thread safety analysis: minor bugfix to smart pointer handling, and expanded 
test case.

llvm-svn: 194157
 2013-11-06 18:40:01 +00:00
DeLesley Hutchins
5ede5cc9ba Thread safety analysis: check pt_guarded_by attribute when calling -> and * 
on smart pointers.  -Wthread-safety-beta only.

llvm-svn: 194103
 2013-11-05 23:09:56 +00:00
Rafael Espindola
7b56f6c3c2 Simplify some implementations of get*Decl. 
* NamedDecl and CXXMethodDecl were missing getMostRecentDecl.
* The const version can just forward to the non const.
* getMostRecentDecl can use cast instead of cast_or_null.

This then removes some casts from the callers.

llvm-svn: 193039
 2013-10-19 16:55:03 +00:00
DeLesley Hutchins
9f5193cf61 Thread Safety Analysis: fix bug when using TryLock with && and || expressions. 
llvm-svn: 188505
 2013-08-15 23:06:33 +00:00
DeLesley Hutchins
16b4ff5c4d Thread safety analysis: move warnings within lock/unlock functions out of beta. 
llvm-svn: 188465
 2013-08-15 15:31:25 +00:00
Aaron Ballman
fcd5b7e76e Updating a link in the comments; no functional change. 
llvm-svn: 185013
 2013-06-26 19:17:19 +00:00
DeLesley Hutchins
3b2c66bbda Thread safety analysis: fix use after free bug reported by Evgeniy Stepanov. 
llvm-svn: 182305
 2013-05-20 17:57:55 +00:00
DeLesley Hutchins
b682431775 Thread safety analysis: add two new attributes to the thread safety analysis: 
assert_exclusive_lock and assert_shared_lock.  These attributes are used to
mark functions that dynamically check (i.e. assert) that a lock is held.

llvm-svn: 182170
 2013-05-17 23:02:59 +00:00
DeLesley Hutchins
fd374bb3dd Thread safety analysis: turn on checking within lock and unlock functions. 
These checks are enabled with the -Wthread-safety-beta flag.

llvm-svn: 179046
 2013-04-08 20:11:11 +00:00
DeLesley Hutchins
c105ba19e9 Thread safety analysis: Turn on checking for non-scalar types by default. 
These were previously enabled as a "beta" feature, but they have now been
extensively tested.

llvm-svn: 178478
 2013-04-01 17:47:37 +00:00
David Blaikie
00be69ab5c Remove the CFGElement "Invalid" state. 
Use Optional<CFG*> where invalid states were needed previously. In the one case
where that's not possible (beginAutomaticObjDtorsInsert) just use a dummy
CFGAutomaticObjDtor.

Thanks for the help from Jordan Rose & discussion/feedback from Ted Kremenek
and Doug Gregor.

Post commit code review feedback on r175796 by Ted Kremenek.

llvm-svn: 175938
 2013-02-23 00:29:34 +00:00
David Blaikie
2a01f5d426 Replace CFGElement llvm::cast support to be well-defined. 
See r175462 for another example/more details.

llvm-svn: 175796
 2013-02-21 20:58:29 +00:00
DeLesley Hutchins
9fa426a666 Thread-safety analysis: ignore edges from throw expressions in CFG. 
llvm-svn: 172858
 2013-01-18 22:15:45 +00:00
Dmitri Gribenko
f857950d39 Remove useless 'llvm::' qualifier from names like StringRef and others that are 
brought into 'clang' namespace by clang/Basic/LLVM.h

llvm-svn: 172323
 2013-01-12 19:30:44 +00:00
DeLesley Hutchins
0cfa1a5a1d Thread-safety analysis: check member access on guarded non-primitive types. 
llvm-svn: 169669
 2012-12-08 03:46:30 +00:00
DeLesley Hutchins
f489d2b86c Thread-safety analysis: check locks on method calls, operator=, and 
copy constructors.

llvm-svn: 169350
 2012-12-05 01:20:45 +00:00
DeLesley Hutchins
5df82f2155 Thread Safety Analysis: refactor to make more methods accept const pointers, 
adjust checkAccess.  No change in functionality.

llvm-svn: 169348
 2012-12-05 00:52:33 +00:00
Chandler Carruth
3a02247dc9 Sort all of Clang's files under 'lib', and fix up the broken headers 
uncovered.

This required manually correcting all of the incorrect main-module
headers I could find, and running the new llvm/utils/sort_includes.py
script over the files.

I also manually added quite a few missing headers that were uncovered by
shuffling the order or moving headers up to be main-module-headers.

llvm-svn: 169237
 2012-12-04 09:13:33 +00:00
Benjamin Kramer
ea70eb30a0 Pull the Attr iteration parts out of Attr.h, so including DeclBase.h doesn't pull in all the generated Attr code. 
Required to pull some functions out of line, but this shouldn't have a perf impact.
No functionality change.

llvm-svn: 169092
 2012-12-01 15:09:41 +00:00
DeLesley Hutchins
1fe885614d Thread-safety analysis: allow attributes on constructors to refer to 'this'. 
llvm-svn: 165339
 2012-10-05 22:38:19 +00:00
DeLesley Hutchins
10958cae09 Thread-safety analysis: better handling of unreachable blocks. Fixes a bug 
where a call to function marked 'noreturn' is followed by unreachable
implicit destructor calls.

llvm-svn: 164394
 2012-09-21 17:57:00 +00:00
DeLesley Hutchins
fcb0ffa622 Thread-safety analysis: fix bug where shared trylock was treated 
as exclusive.

llvm-svn: 164332
 2012-09-20 23:14:43 +00:00